| Summary: | app-editors/vim-core-8.2.3741 file collision with app-editors/vim-8.2.3741 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Adam <adam+gentoo> |
| Component: | Current packages | Assignee: | Vim Maintainers <vim> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dpark, jstein, sam |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=820356 https://github.com/gentoo/gentoo/pull/23986 https://bugs.gentoo.org/show_bug.cgi?id=834447 https://bugs.gentoo.org/show_bug.cgi?id=834498 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Adam
2021-12-28 17:33:00 UTC
@dpark, would you mind looking at this? Thanks! (In reply to Sam James from comment #1) > @dpark, would you mind looking at this? Thanks! ping? Thanks for the reminder. Will soon try to have a look. Yes, I was able to reproduce issue. When I wrote the code, I have not considered the case that vim-core has a different minimal USE flag from vim. To fix the installation conflict, I filed a PR https://github.com/gentoo/gentoo/pull/23986 . With that, at least installation conflicts like that would be gone. Not sure if that would resolve all issues that happen with vim[minimal] and vim-core[-minimal] . Users would get still some warnings at runtime. Not sure how we can fix those. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e4c6279825a758f660237211dfcdfd83399887f4 commit e4c6279825a758f660237211dfcdfd83399887f4 Author: Dongsu Park <dpark@linux.microsoft.com> AuthorDate: 2022-01-27 16:28:09 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-02-18 02:53:32 +0000 app-editors/vim-core: skip installing defaults.vim when installed Do not install defaults.vim when the file is already installed from vim. This is needed for avoiding installation conflicts between vim and vim-core. Closes: https://bugs.gentoo.org/830177 Signed-off-by: Dongsu Park <dpark@linux.microsoft.com> Closes: https://github.com/gentoo/gentoo/pull/23986 Signed-off-by: Sam James <sam@gentoo.org> app-editors/vim-core/vim-core-8.2.0814.ebuild | 10 +++++++--- app-editors/vim-core/vim-core-8.2.3428.ebuild | 10 +++++++--- app-editors/vim-core/vim-core-8.2.3567.ebuild | 10 +++++++--- app-editors/vim-core/vim-core-8.2.3582.ebuild | 10 +++++++--- app-editors/vim-core/vim-core-8.2.3669.ebuild | 10 +++++++--- app-editors/vim-core/vim-core-8.2.3741.ebuild | 10 +++++++--- app-editors/vim-core/vim-core-8.2.3950.ebuild | 10 +++++++--- app-editors/vim-core/vim-core-9999.ebuild | 10 +++++++--- 8 files changed, 56 insertions(+), 24 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=49adc5f0272e40ac608a89d268ee12811fcca384 commit 49adc5f0272e40ac608a89d268ee12811fcca384 Author: Dongsu Park <dpark@linux.microsoft.com> AuthorDate: 2022-01-27 16:23:03 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-02-18 02:53:29 +0000 app-editors/vim: install defaults.vim only if the file is not installed Install defaults.vim only if the file is not installed already from vim-core. That's needed for avoiding conflicts between vim and vim-core. Closes: https://bugs.gentoo.org/830177 Signed-off-by: Dongsu Park <dpark@linux.microsoft.com> Signed-off-by: Sam James <sam@gentoo.org> app-editors/vim/vim-8.2.0814-r100.ebuild | 6 ++++-- app-editors/vim/vim-8.2.3428-r1.ebuild | 6 ++++-- app-editors/vim/vim-8.2.3567.ebuild | 6 ++++-- app-editors/vim/vim-8.2.3582.ebuild | 6 ++++-- app-editors/vim/vim-8.2.3669.ebuild | 6 ++++-- app-editors/vim/vim-8.2.3741.ebuild | 6 ++++-- app-editors/vim/vim-8.2.3950.ebuild | 6 ++++-- app-editors/vim/vim-9999.ebuild | 6 ++++-- 8 files changed, 32 insertions(+), 16 deletions(-) (In reply to Dongsu Park from comment #4) > Yes, I was able to reproduce issue. > > When I wrote the code, I have not considered the case that vim-core has a > different minimal USE flag from vim. > To fix the installation conflict, I filed a PR > https://github.com/gentoo/gentoo/pull/23986 . > With that, at least installation conflicts like that would be gone. > > Not sure if that would resolve all issues that happen with vim[minimal] and > vim-core[-minimal] . > Users would get still some warnings at runtime. > Not sure how we can fix those. Thank you! The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ed9829038751fab208ed07a97a35fa3168edae93 commit ed9829038751fab208ed07a97a35fa3168edae93 Author: Dongsu Park <dpark@linux.microsoft.com> AuthorDate: 2022-02-18 11:27:49 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-02-18 17:56:35 +0000 app-editors/vim-core: fix conflicts in 8.2.{4285,4328} We fixed defaults.vim installation conflicts in e4c6279825a758f660237211dfcdfd83399887f4, but not for 8.2.4285 and 8.2.4328. Fix the issue for the versions. Bug: https://bugs.gentoo.org/830177 Signed-off-by: Dongsu Park <dpark@linux.microsoft.com> Closes: https://github.com/gentoo/gentoo/pull/24247 Signed-off-by: Sam James <sam@gentoo.org> app-editors/vim-core/vim-core-8.2.4285.ebuild | 10 +++++++--- app-editors/vim-core/vim-core-8.2.4328.ebuild | 10 +++++++--- 2 files changed, 14 insertions(+), 6 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=90d47914d37a74bf090f7c5fab43bb8f5084b9ae commit 90d47914d37a74bf090f7c5fab43bb8f5084b9ae Author: Dongsu Park <dpark@linux.microsoft.com> AuthorDate: 2022-02-18 11:27:16 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-02-18 17:56:32 +0000 app-editors/vim: fix conflicts in 8.2.{4285,4328} We fixed defaults.vim installation conflicts in 49adc5f0272e40ac608a89d268ee12811fcca384, but not for 8.2.4285 and 8.2.4328. Fix the issue for the versions. Bug: https://bugs.gentoo.org/830177 Signed-off-by: Dongsu Park <dpark@linux.microsoft.com> Signed-off-by: Sam James <sam@gentoo.org> app-editors/vim/vim-8.2.4285.ebuild | 6 ++++-- app-editors/vim/vim-8.2.4328.ebuild | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) |
