Bug 829950

Summary:	games-roguelike/stone-soup-0.25.1-r102 fails tests: catch.hpp:10717:58: error: call to non-‘constexpr function ‘long int sysconf(int)
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Erik Mackdanz <stasibear>
Status:	RESOLVED FIXED
Severity:	normal	CC:	games
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	803482
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2021-12-25 08:25:08 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-roguelike/stone-soup-0.25.1-r102 fails tests.
Discovered on: amd64 (internal ref: ci)

NOTE:
If you think this is a GCC-11 related issue, please block bug 732706.

Comment 1 Agostino Sarubbo gentoo-dev

2021-12-25 08:25:10 UTC

Created attachment 760185 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2021-12-25 08:25:34 UTC

all other slots fails in the same way

Comment 3 Erik Mackdanz gentoo-dev

2021-12-30 04:26:03 UTC

I can reproduce the issue and will investigate further.  I'm sure upstream has just neglected their test suite.

Comment 4 Sam James archtester

2021-12-30 04:45:04 UTC

(In reply to Erik Mackdanz from comment #3)
> I can reproduce the issue and will investigate further.  I'm sure upstream
> has just neglected their test suite.

They have a bundled copy of catch(2) which needs to be patched, updated, or allow using the system version.

Comment 5 Erik Mackdanz gentoo-dev

2021-12-30 05:05:04 UTC

> They have a bundled copy of catch(2) which needs to be patched, updated, or
> allow using the system version.

Good catch.  Swapping in catch.hpp from the system results in all tests passing.

Comment 6 Larry the Git Cow gentoo-dev

2021-12-30 15:43:48 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2aa8bfe8b2baece61b41e2b3b14798b41b6fbe6b

commit 2aa8bfe8b2baece61b41e2b3b14798b41b6fbe6b
Author:     Erik Mackdanz <stasibear@gentoo.org>
AuthorDate: 2021-12-30 15:43:31 +0000
Commit:     Erik Mackdanz <stasibear@gentoo.org>
CommitDate: 2021-12-30 15:43:31 +0000

    games-roguelike/stone-soup: use system dev-cpp/catch for tests
    
    ... not the bundled one
    
    Closes: https://bugs.gentoo.org/829950
    Signed-off-by: Erik Mackdanz <stasibear@gentoo.org>
    Package-Manager: Portage-3.0.28, Repoman-3.0.3

 games-roguelike/stone-soup/stone-soup-0.25.1-r102.ebuild        | 9 ++++++++-
 games-roguelike/stone-soup/stone-soup-0.26.1-r1.ebuild          | 9 ++++++++-
 games-roguelike/stone-soup/stone-soup-0.27.1.ebuild             | 9 ++++++++-
 games-roguelike/stone-soup/stone-soup-0.28.0_pre20211224.ebuild | 9 ++++++++-
 4 files changed, 32 insertions(+), 4 deletions(-)