Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 828077

Summary: net-misc/ntp - Improve OpenRC script for ntpd
Product: Gentoo Linux Reporter: Brian Evans (RETIRED) <grknight>
Component: Current packagesAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED FIXED    
Severity: normal CC: sam
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: ntpd.rc-r1

Description Brian Evans (RETIRED) gentoo-dev 2021-12-03 14:53:55 UTC
The attached script updates a couple things which effectively is the same as the current model however it follows the modular nature of the declarative syntax.

Removes the duplicating start_stop_daemon_args since --pidfile is automatic with pidfile=
Only have ntpd create the pidfile when forking via command_args_background
Add command_args_foreground for the option not to fork
Comment 1 Brian Evans (RETIRED) gentoo-dev 2021-12-03 14:54:47 UTC
Created attachment 757261 [details]
ntpd.rc-r1

Updated script for ntpd

Signed-off-by: Brian Evans <grknight@gentoo.org>
Comment 2 Larry the Git Cow gentoo-dev 2022-06-03 05:32:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d8c9b791ed0c3c23ef26ded620334d55f2587758

commit d8c9b791ed0c3c23ef26ded620334d55f2587758
Author:     Brian Evans <grknight@gentoo.org>
AuthorDate: 2022-06-03 05:15:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-03 05:29:18 +0000

    net-misc/ntp: improve OpenRC init script for ntpd
    
    The attached script updates a couple things which effectively is the same
    as the current model however it follows the modular nature of the declarative
    syntax.
    
    Changes:
    * Removes the duplicating start_stop_daemon_args since --pidfile is
      automatic with pidfile=
    * Only have ntpd create the pidfile when forking via command_args_background
    * Add command_args_foreground for the option not to fork
    
    Closes: https://bugs.gentoo.org/828077
    Signed-off-by: Brian Evans <grknight@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/ntp/files/ntpd.rc-r2        |  23 ++++++
 net-misc/ntp/ntp-4.2.8_p15-r1.ebuild | 143 +++++++++++++++++++++++++++++++++++
 2 files changed, 166 insertions(+)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-03 05:37:50 UTC
Thanks!