Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 82757

Summary: ARPStar Ebuild
Product: Gentoo Linux Reporter: John Shaw <jtshaw>
Component: New packagesAssignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel>
Status: RESOLVED FIXED    
Severity: enhancement    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://arpstar.sourceforge.net
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: arpstar-0.5.0.ebuild
arpstar-0.5.0.ebuild
arpstar-0.5.0.ebuild
arpstar-0.5.0.ebuild
arpstar-0.5.0.ebuild

Description John Shaw 2005-02-20 20:30:43 UTC
Ebuild for arpstar kernel module.  This module protects against arp poisoning.  It should work for 2.4 and 2.6 kernels.  This is my first new ebuild I've ever submited so please be critical (but not negative:)) if I did something wrong.  I tried to follow the Dev Documentation as close as possible.

Reproducible: Always
Steps to Reproduce:
Comment 1 John Shaw 2005-02-20 20:31:26 UTC
Created attachment 51746 [details]
arpstar-0.5.0.ebuild
Comment 2 John Shaw 2005-02-20 20:32:49 UTC
Created attachment 51747 [details]
arpstar-0.5.0.ebuild
Comment 3 John Shaw 2005-02-20 20:47:12 UTC
Created attachment 51748 [details]
arpstar-0.5.0.ebuild

Fixed some of the einfo statements and the DESCRIPTION statement so things look
a bit better.
Comment 4 John Shaw 2005-02-21 09:58:14 UTC
Created attachment 51793 [details]
arpstar-0.5.0.ebuild

Fixed the bad SRC_URI link for the sourceforge site.

It worked before but always referenced a particular sourceforge mirror... now
it references mirror://sourceforge/... like it should have in the first place.
Comment 5 Stefan Schweizer (RETIRED) gentoo-dev 2005-02-25 05:17:26 UTC
Created attachment 52115 [details]
arpstar-0.5.0.ebuild

The module does not build for me with kernel 2.6.11-rc3-bk9

What kernel do you run?
Can you please try my cleaned-up ebuild?

You might also want to look at it to learn more about ebuilds :)
Comment 6 RockCrusha 2005-02-27 22:21:42 UTC
Stephan, ArpStar-0.5.0 does not compile for kernels less than 2.6.9.  Currently, you would need arpstar-legacy to compile on those kernels.  available at: arpstar.sourceforge.net
Comment 7 RockCrusha 2005-02-27 22:31:58 UTC
Stefan, oh sorry, 2.6.11?  i misread it as 2.6.1, my fault.
As i was saying before, arpstar-legacy for kernels prior to 2.6.9, and ArpStar-0.5.0 has been tested for 2.6.9 and 2.6.10.  cannot vouch for 2.6.11 compatibility yet.
Comment 8 Stefan Schweizer (RETIRED) gentoo-dev 2005-02-28 05:11:11 UTC
Does my ebuild work for you with 2.6.10?
Comment 9 RockCrusha 2005-03-02 16:55:22 UTC
yes it does
Comment 10 Stefan Schweizer (RETIRED) gentoo-dev 2005-03-04 05:32:53 UTC
Thanks, I added the ebuild for kernels 2.6.9 and 2.6.10 only.
Comment 11 John Shaw 2005-03-04 06:02:12 UTC
I used your ebuild with my own vanilla 2.6.11 kernel with the grsec patch applied and it worked fine.
Comment 12 Stefan Schweizer (RETIRED) gentoo-dev 2005-03-04 06:22:46 UTC
It does not for me :(

Does it depend on a special CONFIG_OPTION?
I do not have any iptables stuff selected .. maybe thats it?

My error:


  CC [M]  /var/tmp/portage/arpstar-0.5.0/work/arpstar.o
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c: In function `arpstar_init':
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:292: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:293: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:294: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:295: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:296: warning: implicit declaration of function `nf_register_hook'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:298: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:299: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:300: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:301: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:304: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:305: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:306: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:307: error: invalid use of undefined type `struct nf_hook_ops'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c: In function `arpstar_exit':
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:318: warning: implicit declaration of function `nf_unregister_hook'
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c: In function `print_possible':
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:608: warning: comparison of distinct pointer types lacks a cast
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c: At top level:
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:69: error: storage size of `arphkrcv' isn't known
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:70: error: storage size of `arphksnd' isn't known
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:71: error: storage size of `iphkrcv' isn't known
/var/tmp/portage/arpstar-0.5.0/work/arpstar.c:593: warning: 'print_list' defined but not used
make[2]: *** [/var/tmp/portage/arpstar-0.5.0/work/arpstar.o] Error 1


any idea?
Comment 13 John Shaw 2005-03-04 06:25:32 UTC
It appears that you don't have netfilter support in your kernel.  The nf_hook_ops structure is apart of the netfilter code.
Comment 14 Stefan Schweizer (RETIRED) gentoo-dev 2005-03-04 06:35:22 UTC
ok, I corrected the ebuild, now it depends on CONFIG_NETFILTER and also installs the documentation .. I hope its ok for you that way.

oh .. and it does not stop merging for 2.6.11 any longer ;)
Comment 15 John Shaw 2005-03-04 06:40:56 UTC
Sweet... thanks for the sample of how a kernel modules ebuild should work btw:)
Comment 16 RockCrusha 2005-03-05 23:41:07 UTC
awesome.  arpstar-0.5.5 just came out :)
should be compatible with most/all 2.6 kernels.

Comment 17 Jakub Moc (RETIRED) gentoo-dev 2005-03-06 00:13:35 UTC
 if kernel_is lt 2 6 9
        then
                einfo "This module does not build for kernels <2.6.9"
                die "Kernel too new .."
        fi

Should probably be

                die "Kernel too old .."

;-)
Comment 18 Stefan Schweizer (RETIRED) gentoo-dev 2005-03-06 10:43:57 UTC
version bumped, thanks :)