Bug 825290

Summary:	=sys-auth/fprintd-1.94.0[pam] fails tests
Product:	Gentoo Linux	Reporter:	Marek Szuba <marecki>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	CONFIRMED ---
Severity:	normal	CC:	guyu2876, mscardovi
Priority:	Normal	Keywords:	PullRequest, TESTFAILURE
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://gitlab.freedesktop.org/libfprint/fprintd/-/issues/107
See Also:	https://github.com/gentoo/gentoo/pull/24705
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	fprintd-1.94.0-testlog.txt (riscv) emerge --info (riscv) ebuild log log in starlight

Description Marek Szuba archtester

2021-11-20 11:51:33 UTC

Observed on both ~riscv and ~amd64, that said error messages are quite different so I'm still testing the latter further.

Nb. Both systems in question have had >=sys-libs/pam-1.5.2-r1 masked in order to avoid triggering Bug #825078.

Comment 1 Marek Szuba archtester

2021-11-20 11:52:40 UTC

Created attachment 753878 [details]
fprintd-1.94.0-testlog.txt (riscv)

Comment 2 Marek Szuba archtester

2021-11-20 11:52:59 UTC

Created attachment 753882 [details]
emerge --info (riscv)

Comment 3 Marek Szuba archtester

2022-03-22 15:36:11 UTC

Yu, does 1.94.1 actually pass all the tests on riscv?

Comment 4 ArchFeh(Yu Gu) 2022-03-23 07:36:02 UTC

I test in my bwarp container. It all test passed. If something else I missed, tell me please!

Comment 5 ArchFeh(Yu Gu) 2022-03-23 07:37:26 UTC

Created attachment 767615 [details]
ebuild log

Comment 6 ArchFeh(Yu Gu) 2022-04-04 07:31:00 UTC

Created attachment 768739 [details]
log in starlight

Hi Marek. All tests passed in my board starlight. I think the problem is here. https://gitlab.freedesktop.org/libfprint/fprintd/-/blob/master/pam/pam_fprintd.c#L782
When we ssh in a host, it returns true. I test it using minicomp so it wont be recongnized as remote.

Comment 7 Larry the Git Cow gentoo-dev

2022-04-11 21:05:53 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81b1aacb9030dac0a0df1f9bdbc1248ca98a168a

commit 81b1aacb9030dac0a0df1f9bdbc1248ca98a168a
Author:     Yu Gu <guyu2876@gmail.com>
AuthorDate: 2022-03-22 09:18:23 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2022-04-11 21:05:30 +0000

    sys-auth/fprintd: keyword 1.94.1 for ~riscv
    
    Bug: https://bugs.gentoo.org/825290
    Signed-off-by: Yu Gu <guyu2876@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/24705
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 sys-auth/fprintd/fprintd-1.94.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 8 Marco Scardovi (scardracs) 2022-12-27 20:27:08 UTC

Is this still opened or is it fixed?