Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 825066

Summary: eapply_user(): Improve output
Product: Portage Development Reporter: Arfrever Frehtes Taifersar Arahesis <arfrever.fta>
Component: Core - Ebuild SupportAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal Keywords: InVCS
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Patch
Patch

Description Arfrever Frehtes Taifersar Arahesis 2021-11-19 22:20:19 UTC
epatch_user() function (currently defined in epatch.eclass for EAPI < 6) results in calling:
	einfo "Applying user patches from ${EPATCH_SOURCE} ..."


eapply_user() function (available for EAPI >= 6) does not print any useful message at the beginning of its operation.


I suggest to add similar message and some decoration to allow to easier recognize that user patches are applied.
Comment 1 Arfrever Frehtes Taifersar Arahesis 2021-11-19 22:26:05 UTC
Created attachment 753542 [details, diff]
Patch
Comment 2 Arfrever Frehtes Taifersar Arahesis 2021-11-19 22:42:01 UTC
Created attachment 753546 [details, diff]
Patch

(Improved patch which uses the same 'stty size' fallback as in __set_colors() function.)
Comment 3 Larry the Git Cow gentoo-dev 2021-11-19 23:59:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=47fb9590b57162a786d668f663c1d0dfbfd1cfb0

commit 47fb9590b57162a786d668f663c1d0dfbfd1cfb0
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2021-11-19 22:00:00 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2021-11-19 23:55:08 +0000

    eapply_user(): Add message about applying user patches and minor decoration.
    
    Bug: https://bugs.gentoo.org/825066
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 bin/phase-helpers.sh | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)
Comment 4 Zac Medico gentoo-dev 2021-11-19 23:59:39 UTC
Thanks!
Comment 5 Mike Gilbert gentoo-dev 2022-04-11 20:21:14 UTC
Released in portage-3.0.29.