| Summary: | media-libs/vulkan-loader, dev-util/vulkan-tools, media-libs/vulkan-layers regressed to using cmake-utils.eclass which is DEPRECATED | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Andreas Sturmlechner <asturm> |
| Component: | Current packages | Assignee: | Gentoo X packagers <x11> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | sam, sarnex |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=712090 https://bugs.gentoo.org/show_bug.cgi?id=796662 https://bugs.gentoo.org/show_bug.cgi?id=823077 https://github.com/gentoo/gentoo/pull/23114 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Andreas Sturmlechner
2021-11-07 07:55:15 UTC
...and what caused CMAKE_MAKEFILE_GENERATOR="emake" to be added? The git summary makes no explanation. Hi Andreas, Can you please suggest a better fix to 796662? I discussed this with Sam and we agreed it wasn't an ideal fix but I was a waiting for official Gentoo policy of what NDEBUG should be set to in release builds. Thanks, Nick The solution can never be to revert to deprecated eclass and I doubt Sam suggested that. If you have been waiting for an official Gentoo policy, I haven't seen anyone discussing it either. Pass -DNDEBUG in src_configure() if it is necessary for your package; or better, fix upstream build system so that it does not rely on this variable. Obviously Sam did not suggest that The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=86a8cd6ba02ee38117d18ceff837518c6c13a5dd commit 86a8cd6ba02ee38117d18ceff837518c6c13a5dd Author: Nick Sarnie <sarnex@gentoo.org> AuthorDate: 2021-11-07 15:45:45 +0000 Commit: Nick Sarnie <sarnex@gentoo.org> CommitDate: 2021-11-07 15:57:13 +0000 media-libs/vulkan-layers: Fix eclass Closes: https://bugs.gentoo.org/822249 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Nick Sarnie <sarnex@gentoo.org> .../vulkan-layers/vulkan-layers-1.2.189-r1.ebuild | 57 ++++++++++++++++++++++ media-libs/vulkan-layers/vulkan-layers-9999.ebuild | 11 ++--- 2 files changed, 61 insertions(+), 7 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ae537a654dadc0b7a77d60fa085cd3a12c8cf72d commit ae537a654dadc0b7a77d60fa085cd3a12c8cf72d Author: Nick Sarnie <sarnex@gentoo.org> AuthorDate: 2021-11-07 15:53:44 +0000 Commit: Nick Sarnie <sarnex@gentoo.org> CommitDate: 2021-11-07 15:57:20 +0000 media-libs/vulkan-loader: Fix eclass Bug: https://bugs.gentoo.org/822249 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Nick Sarnie <sarnex@gentoo.org> .../vulkan-loader/vulkan-loader-1.2.189-r1.ebuild | 67 ++++++++++++++++++++++ media-libs/vulkan-loader/vulkan-loader-9999.ebuild | 13 ++--- 2 files changed, 72 insertions(+), 8 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8827b0d229accd44e58e0b3322f51bb97afcbb99 commit 8827b0d229accd44e58e0b3322f51bb97afcbb99 Author: Nick Sarnie <sarnex@gentoo.org> AuthorDate: 2021-11-07 15:51:36 +0000 Commit: Nick Sarnie <sarnex@gentoo.org> CommitDate: 2021-11-07 15:57:16 +0000 dev-util/vulkan-tools: Fix eclass Bug: https://bugs.gentoo.org/822249 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Nick Sarnie <sarnex@gentoo.org> .../vulkan-tools/vulkan-tools-1.2.189-r1.ebuild | 83 ++++++++++++++++++++++ dev-util/vulkan-tools/vulkan-tools-9999.ebuild | 13 ++-- 2 files changed, 88 insertions(+), 8 deletions(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe3e45d944fa300fb72fc561b02f817419ac8824 commit fe3e45d944fa300fb72fc561b02f817419ac8824 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2021-11-29 15:15:49 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2021-11-29 16:51:52 +0000 media-libs/vulkan-layers: Cleanup leading spaces from indendation Bug: https://bugs.gentoo.org/822249 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> media-libs/vulkan-layers/vulkan-layers-1.2.189-r1.ebuild | 2 +- media-libs/vulkan-layers/vulkan-layers-9999.ebuild | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) |