Summary: | sys-apps/fwupd-1.7.1: fails to build with >=dev-util/meson-0.60.0 (ERROR: Unknown options: "agent") | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Duncan <1i5t5.duncan> |
Component: | Current packages | Assignee: | Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | sam, whissi |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/22922 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 821544 |
Description
Duncan
2021-11-03 22:59:47 UTC
Yeah, this changed upstream to become fatal in newer Mesons. (In reply to Duncan from comment #0) > Executive summary: This particular bug seems to be that fwupd lost its > former meson -Dagent option some versions ago Indeed. Looking at meson_options.txt for tags at https://github.com/fwupd/fwupd/ , it appears fwupd-1.6.1 from June 14 was the last containing the agent option. 1.6.2 contains commit f0bc835 "Move all the fwupdagent code to fwupdmgr" https://github.com/fwupd/fwupd/commit/f0bc83576915017a6e7fbee40c55f49f59925c12 which removes the option. So the agent option has been gone for several releases, and I regularly see fwupd bumps so gentoo has gotten at least some of them, but nobody noticed because pre-meson-0.60 the unrecognized option was just a warning and the build continued despite the ebuild specifying the unknown option. With meson-0.60.1 it aborts. FWIW the rest of the git comment for that commit >>> We want to provide a lot more in JSON format in the future, and this will reduce a lot of code duplication. As various people are using this in the wild, the existing fwupdagent binary just shims requests to fwupdmgr as required. We'll stop doing this for 2.0.0 or something. <<< So it appears the option was just removed, not replaced by another, and the lines in the ebuilds passing it, along with the agent USE flag, can be simply removed. (In reply to Duncan from comment #2) > I regularly see fwupd bumps Forgot to say it there but thank you. The timeliness is appreciated. =:^) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=94af023e21271a240cd86af1290e67381e9cf789 commit 94af023e21271a240cd86af1290e67381e9cf789 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2021-11-12 18:24:51 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2021-11-12 18:59:06 +0000 sys-apps/fwupd: drop 'agent' USE flag Closes: https://bugs.gentoo.org/821538 Signed-off-by: Mike Gilbert <floppym@gentoo.org> sys-apps/fwupd/fwupd-1.6.4-r1.ebuild | 3 +-- sys-apps/fwupd/fwupd-1.7.1.ebuild | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) |