| Summary: | net-libs/webkit-gtk: fails to build (fatal error: WebCore/CoordinatedGraphicsLayer.h: No such file or directory) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Sam James <sam> |
| Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ionen, marduk |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 820434 | ||
| Attachments: | build.log.bz2 | ||
|
Description
Sam James
2021-10-27 04:07:40 UTC
Ran into the same on a minimal amd64 chroot, haven't looked in-depth but built fine after I enabled USE=opengl I don't understand how folks on bug 820443 get things going then with this issue here still there. New transient zoom support from https://bugs.webkit.org/show_bug.cgi?id=197002 implements a layerForTransientZoom unconditionally for GTK, which in turn returns and requires a CoordinatedGraphicsLayer, which only exists with USE_OPENGL_OR_ES only (which defines USE_COORDINATED_GRAPHICS and enables all that). I will push the patch fix and a blind workaround to the build failure here, but I suspect it'll still have problems - maybe it'll build but crash and burn at runtime or something. If issues come in, I'm inclined to drop the USE flag support to disable this, unless someone writes an upstreamable patch to wire this up for non-GL cases properly (e.g. not do transient zoom support then or something) (In reply to Mart Raudsepp from comment #2) > If issues come in, I'm inclined to drop the USE flag support to disable this As far as I'm concern I support dropping it, especially on a package like this. About only reason I had it disabled is due to being a minimal test chroot where I test if things work with these flags disabled, i.e. I don't want actually want this. As commented in bug 819384 - they aren't, I'm just confusing USE=-X issues with USE=-opengl issues due to the former dealing with opengl shims stuff and this bugs build.log being there as well from another reporter (understandable - even I got confused). The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4cdf2c4a5caec04852158c6391f4978a84caa4df commit 4cdf2c4a5caec04852158c6391f4978a84caa4df Author: Mart Raudsepp <leio@gentoo.org> AuthorDate: 2022-01-02 22:43:52 +0000 Commit: Mart Raudsepp <leio@gentoo.org> CommitDate: 2022-01-02 22:44:14 +0000 net-libs/webkit-gtk: Drop support for disabling OpenGL Instead of adding a REQUIRED_USE="^^ ( opengl gles2-only )" simplify it to always enable opengl and swap from desktop to ES variant with USE=gles2-only. Closes: https://bugs.gentoo.org/820443 Package-Manager: Portage-3.0.20, Repoman-3.0.2 Signed-off-by: Mart Raudsepp <leio@gentoo.org> net-libs/webkit-gtk/webkit-gtk-2.34.3.ebuild | 48 +++++++--------------------- 1 file changed, 12 insertions(+), 36 deletions(-) |