| Summary: | net-libs/webkit-gtk: fails to build (InspectorCanvasAgent.h:88:25: error: ‘Frame’ has not been declared) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Sam James <sam> |
| Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gentoo |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=830483 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 820434 | ||
| Attachments: |
build.log.bz2
patch |
||
|
Description
Sam James
2021-10-27 04:01:44 UTC
Created attachment 756857 [details, diff]
patch
This patch fixes the build for me. No idea how webkit-gtk builds for anyone without it.
(In reply to Matt Whitlock from comment #1) > This patch fixes the build for me. No idea how webkit-gtk builds for anyone > without it. USE=jumbo-build glues different source files together, so the compiler sees them together as a single .cpp compilation unit, and something glued in front probably has it forward-declared already Confirmed with 2.34.2. Very frustrating. Thanks for the patch Matt! (Modern bloat-browsers are a nightmare!) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=55e70521884cf6143a68a7ead6f65095887f9906 commit 55e70521884cf6143a68a7ead6f65095887f9906 Author: Mart Raudsepp <leio@gentoo.org> AuthorDate: 2022-01-02 22:34:53 +0000 Commit: Mart Raudsepp <leio@gentoo.org> CommitDate: 2022-01-02 22:44:13 +0000 net-libs/webkit-gtk: fix build with USE=-jumbo-build Thanks-to: Matt Whitlock <gentoo@mattwhitlock.name> Closes: https://bugs.gentoo.org/820437 Package-Manager: Portage-3.0.20, Repoman-3.0.2 Signed-off-by: Mart Raudsepp <leio@gentoo.org> .../webkit-gtk/files/2.34.3-non-jumbo-fix.patch | 43 ++++++++++++++++++++++ net-libs/webkit-gtk/webkit-gtk-2.34.3.ebuild | 1 + 2 files changed, 44 insertions(+) looks like patch breaks jumbo-build though
In file included from /var/tmp/portage/net-libs/webkit-gtk-2.34.3/work/webkit-gtk-2.34.3_build/WebCore/DerivedSources/unified-sources/UnifiedSource-950a39b6-36.cpp:1:
/var/tmp/portage/net-libs/webkit-gtk-2.34.3/work/webkitgtk-2.34.3/Source/WebCore/html/track/InbandTextTrack.cpp:36:10: fatal error: TextTrackClient.h: No such file or directory
36 | #include "TextTrackClient.h"
| ^~~~~~~~~~~~~~~~~~~
compilation terminated.
there's simply no TextTrackClient.h in the source trying a revert for 2.34.3-non-jumbo-fix.patch now. re-closing in favour of 820437 The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4329f278bbb89c1661779e72fe04b46aebc8404f commit 4329f278bbb89c1661779e72fe04b46aebc8404f Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2022-01-03 02:38:56 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2022-01-03 02:42:49 +0000 net-libs/webkit-gtk: remove TextTrackClient.h include from the 2.34.3 looks like this hunk got here by mistake. There's no such header in 2.34.3 source. Bug: https://bugs.gentoo.org/820437 Closes: https://bugs.gentoo.org/830483 Acked-by: Sam James <sam@gentoo.org> Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> net-libs/webkit-gtk/files/2.34.3-non-jumbo-fix.patch | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) |