Bug 818154

Summary:	dev-lang/lazarus-2.2.4 calls cc directly
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Amy Liffey <amynka>
Status:	RESOLVED FIXED
Severity:	normal	CC:	proxy-maint, sam, voron1
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/28789
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	243502
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2021-10-14 14:44:25 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-lang/lazarus-2.0.12 calls cc directly.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GCC-11: https://gcc.gnu.org/gcc-11/porting_to.html
As per QA policy, toolchain tools must not be called directly because they can cause issue in cross-compiling and because is not possible use a different CC implementation (like clang). To reproduce, please use sys-devel/gcc-config[-native-symlinks], sys-devel/binutils-config[-native-symlinks].

Comment 1 Agostino Sarubbo gentoo-dev

2021-10-14 14:44:28 UTC

Created attachment 744948 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2021-10-14 14:44:30 UTC

Possible context of error(s):

/bin/sh: line 1: gcc: command not found
Could not find libgcc

Comment 3 Agostino Sarubbo gentoo-dev

2022-02-02 16:09:39 UTC

ci has reproduced this issue with version 2.2.0 - Updating summary.

Comment 4 Agostino Sarubbo gentoo-dev

2022-12-12 19:30:07 UTC

ci has reproduced this issue with version 2.2.4 - Updating summary.

Comment 5 Larry the Git Cow gentoo-dev

2023-01-11 09:41:15 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc4ae6502bc01de42621d6744ebca15b882de5fd

commit dc4ae6502bc01de42621d6744ebca15b882de5fd
Author:     Michael Corvinus <voron1@gmail.com>
AuthorDate: 2022-12-24 21:31:42 +0000
Commit:     Amy Liffey <amynka@gentoo.org>
CommitDate: 2023-01-11 09:40:50 +0000

    dev-lang/lazarus: fix calling `gcc` directly
    
    The build system does things like GCCLIBDIR:=$(shell dirname `gcc -m32 -print-libgcc-file-name`)
    Replace with ${CC}.
    
    Add QA_FLAGS_IGNORED and QA_PRESTRIPPED as FPC doesn't care about CFLAGS and does its own stripping.
    
    Closes: https://bugs.gentoo.org/818154
    Closes: https://bugs.gentoo.org/737060
    
    Signed-off-by: Michael Corvinus <voron1@gmail.com>
    Signed-off-by: Amy Liffey <amynka@gentoo.org>

 dev-lang/lazarus/Manifest                           |  1 +
 ...lazarus-2.2.4.ebuild => lazarus-2.2.4-r1.ebuild} | 21 ++++++++++++++++++---
 2 files changed, 19 insertions(+), 3 deletions(-)

Comment 6 Michael 2023-01-11 09:56:25 UTC

@Agostino Will it reopen if it reproduces the issue after the revbump?