Summary: | net-libs/pjproject silently ignore opus use flag | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ilia Pavlikhin <owl> |
Component: | Current packages | Assignee: | Jaco Kroon <jaco> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | proxy-maint |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Fixing aconfigure.ac for properly OPUS building
Little bit fixed patch (with full fixed behavior) Simple application for listing available codes in PJSIP |
Description
Ilia Pavlikhin
2021-10-11 19:07:22 UTC
Created attachment 744504 [details, diff]
Little bit fixed patch (with full fixed behavior)
I've reworked patch for satisfy behavior:
1. Argument --enable-opus not passed - autochecking and linking to opus
2. Argument --enable-opus passed - autochecking and linking to opus
3. Argument --enable-opus=no passed - disabled linking to opus
4. Argument --disable-opus - same as --enable-opus=no
Created attachment 744507 [details]
Simple application for listing available codes in PJSIP
Building is pretty simple:
g++ -o pjtest -lpjsua2 -lpj pjtest.cpp
Output (depend on enabled codecs of course):
Available codecs:
- speex/16000/1 (priority: 130)
- speex/8000/1 (priority: 129)
- speex/32000/1 (priority: 128)
- GSM/8000/1 (priority: 128)
- PCMU/8000/1 (priority: 128)
- PCMA/8000/1 (priority: 128)
- G722/16000/1 (priority: 128)
- opus/48000/2 (priority: 128)
- L16/44100/2 (priority: 0)
- L16/44100/1 (priority: 0)
Yes, same problem in FFMPEG part. I think fix of ebuild will be simpler, than fix upstream aconfigure.ac. Just don't pass any --enable-FEATURE flag if it's already enabled by default. I've previously created PRs for --enabled,disable}-ssl too. They're not interested. I've now gone through the ./configure for all options, and adjusted as needed (all of them). It should be noted that asterisk doesn't need any of this, other than ssl, which is probably why none of this was ever properly picked up. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74bc4476b50218718af7c43038176f1d69c50e61 commit 74bc4476b50218718af7c43038176f1d69c50e61 Author: Jaco Kroon <jaco@uls.co.za> AuthorDate: 2021-07-24 08:36:57 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-06-15 13:32:11 +0000 net-libs/pjproject: Version 2.12.1. Upstream release. Remove the need for custom patches (which is still required but no longer applies, instead, rely on ./configure detecting openssl, we do depend on it, and only --disable-ssl works, passing --enable-ssl also effectively disables ssl). Compile tested asterisk 13, 16 and 18 (in-tree versions) against this. Would appreciate a double-check on this one. One version from each is sufficient. Since the two libraries that were the target of parallel build failures are now one, I believe the parallel build issue is fixed too. Included patch for CVE-2022-31031 Closes: https://bugs.gentoo.org/833765 Closes: https://bugs.gentoo.org/817803 Closes: https://bugs.gentoo.org/808099 Closes: https://bugs.gentoo.org/834491 Bug: https://bugs.gentoo.org/803614 Bug: https://bugs.gentoo.org/765799 Bug: https://bugs.gentoo.org/829894 Package-Manager: Portage-3.0.20, Repoman-3.0.2 Signed-off-by: Jaco Kroon <jaco@uls.co.za> Closes: https://github.com/gentoo/gentoo/pull/21761 Signed-off-by: Joonas Niilola <juippis@gentoo.org> net-libs/pjproject/Manifest | 1 + .../files/pjproject-2.12.1-CVE-2022-31031.patch | 41 +++++++ net-libs/pjproject/pjproject-2.12.1.ebuild | 125 +++++++++++++++++++++ 3 files changed, 167 insertions(+) |