Summary: | sys-kernel/gentoo-kernel-bin: CONFIG_FW_LOADER_USER_HELPER should not be set | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Anton Bolshakov <anton.bugs> |
Component: | Current packages | Assignee: | Distribution Kernel Project <dist-kernel> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | CC: | bugzilla, cedk, me |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Anton Bolshakov
2021-10-06 09:26:32 UTC
*** Bug 827715 has been marked as a duplicate of this bug. *** I also reproduced it with sys-kernel/gentoo-kernel (source-based ones). This probably affects *all* kernel variants if certain kernel config options are set, CONFIG_DELL_RBU in particular. For example, in kernel v5.16.9 (vanilla kernel.org + irrelevant local patchset): Symbol: FW_LOADER_USER_HELPER [=y] Type : bool Defined at drivers/base/firmware_loader/Kconfig:71 Prompt: Enable the firmware sysfs fallback mechanism Depends on: FW_LOADER [=y] Location: Main menu -> Device Drivers -> Generic Driver Options -> Firmware loader -> Firmware loading facility (FW_LOADER [=y]) Selects: FW_LOADER_PAGED_BUF [=y] Selected by [m]: - DELL_RBU [=m] && X86_PLATFORM_DEVICES [=y] && X86_PLATFORM_DRIVERS_DELL [=y] && X86 [=y] Selected by [n]: - LEDS_LP55XX_COMMON [=n] && NEW_LEDS [=y] && LEDS_CLASS [=m] && (LEDS_CLASS_MULTICOLOR [=n] || !LEDS_CLASS_MULTICOLOR [=n]) && OF [=n] && I2C [=m] Note the "selected by" field: I can't disable CONFIG_FW_LOADER_USER_HELPER unless I also disable DELL_RBU. However, I definitely want to keep DELL_RBU enabled -- I administer ~70 Dell systems for a university and would strongly prefer to retain the capability to install BIOS updates on live systems... (The alternative is visiting those ~70 systems in person to manually boot each one from removable media and install the BIOS update, which also implies ~10min+ downtime per system that a remote BIOS update could have completely avoided. Ugh.) That being the case, I'm not convinced that it makes much sense to have sys-fs/udev warn about CONFIG_FW_LOADER_USER_HELPER=y. Maybe change the loglevel to "info" & rephrase "should not be set. But it is" to something like "is not supported by ${PF}"? (A more appropriate log level would lie somewhere between "warning" and "info" IMO :/) Presumably sys-fs/udev might not actually support the file-loading mechanism that CONFIG_DELL_RBU & CONFIG_LEDS_LP55XX_COMMON use, but who says I'm relying on udev for that functionality? The current warning effectively hardcodes the assumption that I am. The counter-argument is "it's just a warning, if you know what you're doing you can ignore it" -- which isn't entirely wrong. It's just a bit jarring to receive a warning while merging sys-fs/udev about an implied "incorrect" kernel config setting which isn't necessarily incorrect in practice. (Jarring enough that I actually took the time to look for, find, and reply to this bug even though I already know I can ignore it on my systems) |