Bug 815274 – games-fps/gzdoom-4.7.0 version bump

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description William Breathitt Gray 2021-09-29 03:51:04 UTC]

GZDoom version 4.7.0 was released on September 22, 2021: https://github.com/coelckers/gzdoom/releases/tag/g4.7.0

The current gzdoom ebuild is missing support for the HAVE_GLES2 and HAVE_VULKAN options; it would be nice to include support for those in this version bump.

In addition, the release announcement mentions that some sort of telemetry was enabled in this build. I briefly skimmed the CMakeList changes for this release, but did't see an obvious option to disable this telemetry so this version bump may need a custom patch to allow users to disable the telemetry.

It looks like this version bump will require a little extra time devoted to tracking down the telemetry code. I'll be preoccupied this October, so probably in November I can look into this. Otherwise, if anyone wants to take a stab at it sooner I'll gladly provide a review for your changes.

[Comment 1 William Breathitt Gray 2021-10-01 07:05:17 UTC]

Looks like the following commit is where the survey is enabled: https://github.com/coelckers/gzdoom/commit/569517c2debe8791a92bc62837f45b519e50b0a0

So defining the NO_SEND_STATS preprocessor define should disable the survey code.

[Comment 2 James Le Cuirot 2021-10-01 08:32:36 UTC]

I personally don't mind telemetry on this project, so a USE flag would be good.

[Comment 3 William Breathitt Gray 2021-10-02 00:52:33 UTC]

I agree, a USE flag would be the best option here and should be trivial now that we know a simple preprocessor define can toggle the code. I add the 'telemetry' USE flag then when I submit this version bump.

[Comment 4 Larry the Git Cow 2021-10-09 22:20:48 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f7e4330240ab0d0aea5b1617c54c6d8cedd65fc3

commit f7e4330240ab0d0aea5b1617c54c6d8cedd65fc3
Author:     William Breathitt Gray <[e-mail]>
AuthorDate: 2021-10-02 08:54:16 +0000
Commit:     James Le Cuirot <[e-mail]>
CommitDate: 2021-10-09 22:12:05 +0000

    games-fps/gzdoom: Version bump to 4.7.0
    
    The gles2, telemetry, and vulkan USE flags are introduced.
    
    Closes: https://bugs.gentoo.org/815274
    Signed-off-by: William Breathitt Gray <[e-mail]>
    Signed-off-by: James Le Cuirot <[e-mail]>

 games-fps/gzdoom/Manifest            |  1 +
 games-fps/gzdoom/gzdoom-4.7.0.ebuild | 86 ++++++++++++++++++++++++++++++++++++
 games-fps/gzdoom/metadata.xml        |  2 +
 3 files changed, 89 insertions(+)

[Comment 5 Larry the Git Cow 2021-10-23 07:39:11 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df34395764ddccaa2fe8454d739802be4aa3c0c4

commit df34395764ddccaa2fe8454d739802be4aa3c0c4
Author:     William Breathitt Gray <[e-mail]>
AuthorDate: 2021-10-23 01:38:14 +0000
Commit:     James Le Cuirot <[e-mail]>
CommitDate: 2021-10-23 07:34:44 +0000

    games-fps/gzdoom: Version bump to 4.7.1
    
    Closes: https://bugs.gentoo.org/815274
    Signed-off-by: William Breathitt Gray <[e-mail]>
    Signed-off-by: James Le Cuirot <[e-mail]>

 games-fps/gzdoom/Manifest                          |  1 +
 ...-4.7.1-Introduce-the-BUILD_NONFREE-option.patch | 36 ++++++++++
 games-fps/gzdoom/gzdoom-4.7.1.ebuild               | 82 ++++++++++++++++++++++
 3 files changed, 119 insertions(+)

[Comment 6 Sam James 2021-10-23 09:38:13 UTC]

*** Bug 819558 has been marked as a duplicate of this bug. ***