Summary: | net-misc/dhcpcd: No check for CONFIG_PACKET requirement | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Anthony Ryan <anthonyryan1> |
Component: | Current packages | Assignee: | William Hubbs <williamh> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | base-system |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/22417 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Anthony Ryan
2021-09-27 02:06:23 UTC
Pull request submitted: https://github.com/gentoo/gentoo/pull/22417 Do we also need to check for CONFIG_INET? Where do we draw the line on checking for kernel config options? I think CONFIG_PACKET is an acceptable line for a couple of reasons. 1. I don't think there's an expectation of DHCP working without CONFIG_INET. 2. Not everyone is aware that DHCP doesn't use TCP or UDP 3. This has happened enough times that CONFIG_PACKET has been mentioned in the wiki for years: https://wiki.gentoo.org/wiki/Dhcpcd Also of note, if this is acceptable to the developers. I do intend to send a follow up bug/pull for net-wireless/wpa_supplicant with the same rationale. The installation handbook feels the need to have a warning about CONFIG_PACKET in it: https://wiki.gentoo.org/wiki/Handbook:Parts/Networking/Wireless#WPA_supplicant I think it's an improvement to get these kernel dependencies documented in the ebuild rather than the wiki. I started a discussion on the mailing list. https://archives.gentoo.org/gentoo-dev/message/fc20b4c883510a2cacc13a72132a86a9 I'm going to close this issue and the corresponding pull request. There is still a lack of consensus that this is a good idea. "When in doubt, do nothing." |