Bug 815031

Summary:	dev-vcs/git-pw-2.1.1 fails tests
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Yixun Lan <dlan>
Status:	RESOLVED FIXED
Severity:	normal	CC:	matthew
Priority:	Normal	Keywords:	UPSTREAM
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/getpatchwork/git-pw/pull/64
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log Patch to fix tests

Description Agostino Sarubbo gentoo-dev

2021-09-26 17:46:04 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-vcs/git-pw-2.1.1 fails tests.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GCC-11: https://gcc.gnu.org/gcc-11/porting_to.html
If you think this is a GCC-11 related issue, please block bug 732706.

Comment 1 Agostino Sarubbo gentoo-dev

2021-09-26 17:46:06 UTC

CC'ing also the author of the commit (b3a791ce4d2681f2c5e93809ad01a413daf99684)

Comment 2 Agostino Sarubbo gentoo-dev

2021-09-26 17:46:07 UTC

Created attachment 741549 [details]
build.log

build log and emerge --info

Comment 3 Matthew Smith gentoo-dev

2021-09-26 18:50:33 UTC

The test passes with `PAGER=less ebuild git-pw-2.1.1.ebuild test` but fails with `PAGER=/usr/bin/less`.

All of the other tests patch os.environ but this one does not. I'll send a patch upstream.

Comment 4 Matthew Smith gentoo-dev

2021-09-26 18:58:03 UTC

Created attachment 741552 [details, diff]
Patch to fix tests

Comment 5 Larry the Git Cow gentoo-dev

2021-09-30 01:29:23 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c092ede25d5a926be067fbf53f5b3c17143f965

commit 2c092ede25d5a926be067fbf53f5b3c17143f965
Author:     Yixun Lan <dlan@gentoo.org>
AuthorDate: 2021-09-30 01:27:33 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2021-09-30 01:27:33 +0000

    dev-vcs/git-pw: fix tests error
    
    Thanks Matt Smith for contribution
    
    Closes: https://bugs.gentoo.org/815031
    Package-Manager: Portage-3.0.23, Repoman-3.0.3
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 dev-vcs/git-pw/files/git-pw-2.1.1-test.patch | 28 ++++++++++++++++++++++++++++
 dev-vcs/git-pw/git-pw-2.1.1.ebuild           |  2 ++
 2 files changed, 30 insertions(+)