Bug 815022

Summary:	kde-apps/konqueror-21.08.1 with kde-frameworks/kio-5.86.0: Opens every url in separate window (and the default browser)
Product:	Gentoo Linux	Reporter:	Zoltan Puskas <zoltan>
Component:	Current packages	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sam
Priority:	Normal	Keywords:	PATCH, UPSTREAM
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugs.kde.org/show_bug.cgi?id=442636
See Also:	https://invent.kde.org/network/konqueror/-/merge_requests/90
Whiteboard:	fixed in 21.08.2
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	816042
Attachments:	Upstream KIO compatibility patch kf-5.86-compat.patch

Description Zoltan Puskas 2021-09-26 17:27:54 UTC

Latest Konqueror will open every URL whether typed into the address bar, using the search box, or opening a bookmark in a new window. 

On top of that if the default browser in KDE is set to something other than Konqueror (e.g. Firefox) all the links actually open in the designated default browser.

Downgrading kio-5.85.0 is can be used temporarily to mitigate the problem.

Upstream is aware of the problem: https://bugs.kde.org/show_bug.cgi?id=442636

Comment 1 Zoltan Puskas 2021-09-26 17:38:07 UTC

Created attachment 741546 [details, diff]
Upstream KIO compatibility patch

I've compiled Konqueror with upstream's KIO compatibility patch and Konqueror seems to be working again as intended. 

Note that patch applies with some fuzz, so it may need a bit of backporting work for it to be a clean patch before adding it to the tree.

Comment 2 Andreas Sturmlechner gentoo-dev

2021-09-29 11:11:44 UTC

The patch you attached is from master and would break the string freeze (=broken translations).

Does https://invent.kde.org/network/konqueror/-/commit/6a46c0c8701fbde143a33e4be61f198e98f53c10 on its own help too?

Comment 3 Andreas Sturmlechner gentoo-dev

2021-09-30 12:39:43 UTC

While testing konqueror with a possible backport as suggested by upstream in the bug report, I am wondering: how is anyone actually using this for browsing? It is failing to load/hanging/crashing on almost every website I try with.

Comment 4 Andreas Sturmlechner gentoo-dev

2021-09-30 12:41:04 UTC

Created attachment 742188 [details, diff]
kf-5.86-compat.patch

Here is a patch for you to test instead of the one from git master, anyway.

Comment 5 Larry the Git Cow gentoo-dev

2021-10-03 11:46:00 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c322214967d93dd6ad80fa992366f5a1177fa7f0

commit c322214967d93dd6ad80fa992366f5a1177fa7f0
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-10-03 11:18:46 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-10-03 11:45:50 +0000

    kde-apps/konqueror: Fix compatibility with KDE Frameworks 5.86
    
    Closes: https://bugs.gentoo.org/815022
    Package-Manager: Portage-3.0.26, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/konqueror-21.04.3-kf-5.86-compat.patch   | 250 +++++++++++++++++++++
 kde-apps/konqueror/konqueror-21.04.3-r2.ebuild     |  91 ++++++++
 kde-apps/konqueror/konqueror-21.08.1-r2.ebuild     |  92 ++++++++
 3 files changed, 433 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07d9a46287411b1a04c9ee208c63b1cb41823402

commit 07d9a46287411b1a04c9ee208c63b1cb41823402
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-10-03 11:19:43 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-10-03 11:45:50 +0000

    kde-apps/konqueror: Drop 21.08.1 (r0)
    
    Bug: https://bugs.gentoo.org/815022
    Package-Manager: Portage-3.0.26, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/konqueror/konqueror-21.08.1-r1.ebuild | 90 --------------------------
 1 file changed, 90 deletions(-)