Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 814212

Summary: media-gfx/exiv2: Add BMFF support
Product: Gentoo Linux Reporter: goeland86
Component: Current packagesAssignee: Gentoo KDE team <kde>
Status: RESOLVED FIXED    
Severity: enhancement CC: sam, sander
Priority: Normal Keywords: EBUILD
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Updated ebuild for the latest release of exiv2 adding a local use flag to enable/disable ISOBMFF support

Description goeland86 2021-09-21 19:37:04 UTC
Created attachment 740562 [details]
Updated ebuild for the latest release of exiv2 adding a local use flag to enable/disable ISOBMFF support

Per the discussions on the exiv2 github (https://github.com/Exiv2/exiv2/issues/1229#issuecomment-727190658) regarding ISOBMFF (required for CR3 and 2 other file format support), the release 0.27.4 supports it if enabled in the build.

The current CMake arguments list for building exiv2 on Gentoo does not include this option.

I propose an updated ebuild which includes a new package-specific use flag to enable ISOBMFF support, which then in turn enables darktable to support CR3 files. I will later file a separate update for the darktable ebuild introducing a cr3 use-flag to make sure this one is activate for the exiv2 build, as this is a highly anticipated support feature (see https://github.com/darktable-org/darktable/issues/2170#issuecomment-921237592)

I'm happy to provide any other information needed.
Comment 1 goeland86 2021-09-21 19:40:33 UTC
For more clarity:

The specific file formats the ISOBMFF support brings to Darktable (and other dependencies) are CR3, AVIF, HEIF. This is a significant added value in my opinion.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-09-21 19:42:45 UTC
Would you mind attaching a git am-able patch, with the GCO sign off included?
Comment 3 goeland86 2021-09-21 20:00:03 UTC
I can provide a patch file, but not sure how to make the am-able patch with the sign off included version.

Would it be easier if I submitted as a PR through github? I can patch the link here easily enough.
Comment 4 goeland86 2021-09-21 20:06:47 UTC
PR on Github is here: https://github.com/gentoo/gentoo/pull/22361
Comment 5 Larry the Git Cow gentoo-dev 2021-09-25 02:50:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0a701d1456974ba5e8ce8b69809889c2c569271

commit a0a701d1456974ba5e8ce8b69809889c2c569271
Author:     Jon C <goeland86@gmail.com>
AuthorDate: 2021-09-21 19:57:56 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-09-25 02:50:28 +0000

    media-gfx/exiv2: Add ISOBMFF build option
    
    Closes: https://bugs.gentoo.org/814212
    Signed-off-by: Jon Charnas <goeland86@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-gfx/exiv2/exiv2-0.27.4-r2.ebuild | 3 ++-
 media-gfx/exiv2/metadata.xml           | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-09-30 01:15:13 UTC
*** Bug 811846 has been marked as a duplicate of this bug. ***