| Summary: | app-misc/khard-0.17.0-r1 uses a probably incorrect DISTUTILS_USE_SETUPTOOLS value | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | Current packages | Assignee: | Andriy Utkin (RETIRED) <andrey_utkin> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | holgersson, ionen, proxy-maint |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 812431 | ||
| Attachments: | build.log | ||
|
Description
Agostino Sarubbo
2021-09-20 10:36:35 UTC
Created attachment 740283 [details]
build.log
build log and emerge --info
Doesn't reproduce.
The build.log you attached lists
> * QA Notice: DISTUTILS_USE_SETUPTOOLS value is probably incorrect
> * have: DISTUTILS_USE_SETUPTOOLS=rdepend
> * expected: (unset)
I can't find the logic in current eclasses, nor in portage's install-qa-check.d.
Has the code producing this notice been dropped?
Does that mean I can close the bug?
If not, may I ask for some explanation why there's a suspicion of incorrectness?
It's from install-qa-check.d/60distutils-use-setuptools I just gave it a try (on ~amd64) and it was there for me: * Messages for package app-misc/khard-0.17.0-r1: * Log file: /var/log/portage/app-misc:khard-0.17.0-r1:20211116-173030.log.gz * QA Notice: DISTUTILS_USE_SETUPTOOLS value is probably incorrect * have: DISTUTILS_USE_SETUPTOOLS=rdepend * expected: (unset) Do you have qa in PORTAGE_ELOG_CLASSES? Without it, it'll be earlier in your build log rather than shown at the end. The QA check looks at the package's dependencies (as set by upstream), if setuptools is not listed then it suspects it may be wrong to be RDEPEND. That may not always be right though, perhaps upstream is missing a dependency (in which case could patch and report upstream), preferable to check if it runs fine without it to be sure (fwiw my binpkg-only server doesn't have setuptools, so it matters) The default value, bdepend, seems reasonable in this case. I'm going to drop the line `DISTUTILS_USE_SETUPTOOLS=rdepend` from both ebuilds (which are stable). We certainly don't want to trigger rebuilds. For the record, that line was introduced by commits 0667adfa7f4d, cca5e801c584. (FWIW the QA tooling and the upstream behaviour has actually changed recently here.) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=962282cf2a9b32076b902323645463bf532f6016 commit 962282cf2a9b32076b902323645463bf532f6016 Author: Andrey Utkin <andrey_utkin@gentoo.org> AuthorDate: 2021-12-21 16:44:15 +0000 Commit: Andrey Utkin <andrey_utkin@gentoo.org> CommitDate: 2021-12-21 16:49:19 +0000 app-misc/khard: drop incorrect distutils eclass setting Bug: https://bugs.gentoo.org/814026 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Andrey Utkin <andrey_utkin@gentoo.org> app-misc/khard/khard-0.13.0-r1.ebuild | 1 - app-misc/khard/khard-0.17.0-r1.ebuild | 1 - 2 files changed, 2 deletions(-) (In reply to Andrey Utkin from comment #4) > The default value, bdepend, seems reasonable in this case. > I'm going to drop the line `DISTUTILS_USE_SETUPTOOLS=rdepend` from both > ebuilds (which are stable). We certainly don't want to trigger rebuilds. > For the record, that line was introduced by commits 0667adfa7f4d, > cca5e801c584. I'm interested in why you couldn't see the warning. Could you see it in the end? (Again note that behaviour did change.) I managed to see the warning after setting PORTAGE_ELOG_CLASSES=qa . |
