Bug 81313

Summary:	net-firewall/firehol init script doesn't use $FIREHOL_CONF for "try" action
Product:	Gentoo Linux	Reporter:	Adam Chodorowski <adam>
Component:	Current packages	Assignee:	Dominik Stadler (RETIRED) <centic>
Status:	RESOLVED FIXED
Severity:	normal	CC:	flash3001
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Fix to firehol init.d script

Description Adam Chodorowski 2005-02-08 17:37:35 UTC

The init script for FireHOL 1.226 (and probably earlier versions) doesn't use $FIREHOL_CONF in the "try" action, which thus doesn't work if you don't use the default location.

Reproducible: Always
Steps to Reproduce:
1. Move fireholconf and change FIREHOL_CONF in /etc/conf.d/firehol to reflect this
2. Run /etc/init.d/firehol try

Actual Results:  
Error message stating /etc/firehol/firehol.conf couldn't be read.

Expected Results:  
Used the value of $FIREHOL_CONF to find the config file.

Portage 2.0.51-r15 (!/usr/portage/profiles/hardened/x86/2.6, gcc-3.3.5,
glibc-2.3.4.20040808-r1, 2.6.10-hardened-r3 i686)
=================================================================
System uname: 2.6.10-hardened-r3 i686 AMD Duron(tm) Processor
Gentoo Base System version 1.4.16
Python:              dev-lang/python-2.3.4-r1 [2.3.4 (#1, Feb  8 2005, 01:09:46)]
dev-lang/python:     2.3.4-r1
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.5, 1.4_p6, 1.6.3, 1.9.4
sys-devel/binutils:  2.15.92.0.2-r1
sys-devel/libtool:   1.5.10-r4
virtual/os-headers:  2.6.8.1-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon -O3 -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon -O3 -fomit-frame-pointer -pipe"
DISTDIR="/var/cache/download"
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox strict userpriv
usersandbox"
GENTOO_MIRRORS="ftp://mirror.pudas.net/gentoo http://gentoo.oregonstate.edu
http://www.ibiblio.org/pub/Linux/distributions/gentoo"
LC_ALL="C"
MAKEOPTS="-j2"
PKGDIR="/usr/portage//packages/x86/"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/db/portage/gentoo"
PORTDIR_OVERLAY="/var/db/portage/local"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="3dnow alsa cdr crypt dlloader gpm hardened ipv6 mmx ncurses nptl pam pcre
pic pie readline ssl tcpd unicode x86 xml2 zlib"
Unset:  ASFLAGS, CBUILD, CTARGET, LANG, LDFLAGS

Comment 1 Adam Chodorowski 2005-02-08 17:40:50 UTC

Created attachment 50795 [details, diff]
Fix to firehol init.d script

Patch to fix this bug.

Comment 2 Dominik Stadler (RETIRED) gentoo-dev

2005-02-12 12:40:57 UTC

I have checked in a fixed script that sets the config-file correctly. Versions 1.224, 1.226 and the new 1.226-r1 should all install the fixed version now.