Summary: | dev-python/setuptools_scm_git_archive-1.1-r2 fails with dev-python/setuptools_scm > 6.0.1 - TypeError: can't use a string pattern on a bytes-like object | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Pacho Ramos <pacho> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dharding, drmccoy, dschridde+gentoobugs, gentoo, herrtimson, python, sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/Changaco/setuptools_scm_git_archive/issues/19 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge-info.txt
dev-python:pikepdf-2.16.1:20210904-093758.log emerge-history.txt environment etc.portage.tar.bz2 temp.tar.bz2 |
Description
Toralf Förster
2021-09-04 09:45:10 UTC
Created attachment 737449 [details]
emerge-info.txt
Created attachment 737452 [details]
dev-python:pikepdf-2.16.1:20210904-093758.log
Created attachment 737455 [details]
emerge-history.txt
Created attachment 737458 [details]
environment
Created attachment 737461 [details]
etc.portage.tar.bz2
Created attachment 737464 [details]
temp.tar.bz2
Let's see what upstream say at https://github.com/Changaco/setuptools_scm_git_archive/issues/19#issuecomment-912952427 In the meantime, downgrading setuptools_scm to 6.0.1-r1 is a workaround. I have just observed (on both amd64 and riscv) that dev-python/setuptools_scm_git_archive-1.1-r2 fails tests with dev-python/setuptools_scm-6.3.0-r1 present, with the same error. They do pass against setuptools_scm-6.0.1-r1. BTW. This should probably be a setuptools_scm_git_archive issue, not a pikepdf one. You are right, I renamed the bug. I guess we need to require an older setuptools_scm version to work around this The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a5d15943773df5714949633c16ae0b7303d3337 commit 7a5d15943773df5714949633c16ae0b7303d3337 Author: Louis Sautier <sbraz@gentoo.org> AuthorDate: 2021-09-10 11:41:54 +0000 Commit: Louis Sautier <sbraz@gentoo.org> CommitDate: 2021-09-10 11:44:45 +0000 dev-python/setuptools_scm_git_archive: require setuptools_scm<6.1.0 Bug: https://bugs.gentoo.org/811573 Signed-off-by: Louis Sautier <sbraz@gentoo.org> ...t_archive-1.1-r2.ebuild => setuptools_scm_git_archive-1.1-r3.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) It looks like setuptools_scm (dependency of setuptools_scm_git_archive) have pushed a fix for this problem: https://github.com/pypa/setuptools_scm/commit/e2d9f973271d78fec75bd52dde66c89c0392afa8 Could you check if this fix does indeed fix our problem? (In reply to Arthur Zamarin from comment #11) > It looks like setuptools_scm (dependency of setuptools_scm_git_archive) have > pushed a fix for this problem: > https://github.com/pypa/setuptools_scm/commit/ > e2d9f973271d78fec75bd52dde66c89c0392afa8 > > Could you check if this fix does indeed fix our problem? Tests still fail with setuptools_scm 6.3.2 (In reply to Louis Sautier (sbraz) from comment #12) > (In reply to Arthur Zamarin from comment #11) > > It looks like setuptools_scm (dependency of setuptools_scm_git_archive) have > > pushed a fix for this problem: > > https://github.com/pypa/setuptools_scm/commit/ > > e2d9f973271d78fec75bd52dde66c89c0392afa8 > > > > Could you check if this fix does indeed fix our problem? > > Tests still fail with setuptools_scm 6.3.2 I'm puzzled. I copied setuptools_scm_git_archive-1.1-r3 into my local portage as 1.1-r4, removing the setuptools_scm restriction and re-emerged. genlop -l shows: Sat Oct 16 07:31:32 2021 >>> dev-python/setuptools_scm-6.3.2 Sat Oct 16 07:31:43 2021 >>> dev-python/setuptools_scm_git_archive-1.1-r4 Sat Oct 16 07:32:50 2021 >>> dev-python/pikepdf-2.16.1 (In reply to Norman Back from comment #13) > (In reply to Louis Sautier (sbraz) from comment #12) > > (In reply to Arthur Zamarin from comment #11) > > > It looks like setuptools_scm (dependency of setuptools_scm_git_archive) have > > > pushed a fix for this problem: > > > https://github.com/pypa/setuptools_scm/commit/ > > > e2d9f973271d78fec75bd52dde66c89c0392afa8 > > > > > > Could you check if this fix does indeed fix our problem? > > > > Tests still fail with setuptools_scm 6.3.2 > > I'm puzzled. I copied setuptools_scm_git_archive-1.1-r3 into my local > portage as 1.1-r4, removing the setuptools_scm restriction and re-emerged. > genlop -l shows: > > Sat Oct 16 07:31:32 2021 >>> dev-python/setuptools_scm-6.3.2 > Sat Oct 16 07:31:43 2021 >>> > dev-python/setuptools_scm_git_archive-1.1-r4 > Sat Oct 16 07:32:50 2021 >>> dev-python/pikepdf-2.16.1 You tried the test suite? (In reply to Sam James from comment #14) > (In reply to Norman Back from comment #13) > > (In reply to Louis Sautier (sbraz) from comment #12) > > > (In reply to Arthur Zamarin from comment #11) > > > > It looks like setuptools_scm (dependency of setuptools_scm_git_archive) have > > > > pushed a fix for this problem: > > > > https://github.com/pypa/setuptools_scm/commit/ > > > > e2d9f973271d78fec75bd52dde66c89c0392afa8 > > > > > > > > Could you check if this fix does indeed fix our problem? > > > > > > Tests still fail with setuptools_scm 6.3.2 > > > > I'm puzzled. I copied setuptools_scm_git_archive-1.1-r3 into my local > > portage as 1.1-r4, removing the setuptools_scm restriction and re-emerged. > > genlop -l shows: > > > > Sat Oct 16 07:31:32 2021 >>> dev-python/setuptools_scm-6.3.2 > > Sat Oct 16 07:31:43 2021 >>> > > dev-python/setuptools_scm_git_archive-1.1-r4 > > Sat Oct 16 07:32:50 2021 >>> dev-python/pikepdf-2.16.1 > > You tried the test suite? I don't think I have access to that. (In reply to Sam James from comment #14) <snip> > > You tried the test suite? My point is that the fix to dev-python/setuptools_scm-6.3.2 allows the merge of setuptools_scm_git_archive-1.1-r3 on my box when the restiction has been removed. (In reply to Norman Back from comment #16) > (In reply to Sam James from comment #14) > <snip> > > > > You tried the test suite? > > My point is that the fix to dev-python/setuptools_scm-6.3.2 allows the merge > of > setuptools_scm_git_archive-1.1-r3 on my box when the restiction has been > removed. I just checked my Dockerfile from https://github.com/Changaco/setuptools_scm_git_archive/issues/19#issuecomment-915634768 and it seems to work now. I'll try the test suite again and unmask if I can confirm that everything works correctly. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3f9fd5e77afd20e2f3a449a9149bfb591e4a28c9 commit 3f9fd5e77afd20e2f3a449a9149bfb591e4a28c9 Author: Louis Sautier <sbraz@gentoo.org> AuthorDate: 2021-10-20 17:54:57 +0000 Commit: Louis Sautier <sbraz@gentoo.org> CommitDate: 2021-10-20 18:02:00 +0000 dev-python/setuptools_scm_git_archive: lift setuptools_scm restrict. setuptools_scm 6.3.2 works fine with setuptools_scm_git_archive. Closes: https://bugs.gentoo.org/811573 Signed-off-by: Louis Sautier <sbraz@gentoo.org> ...t_archive-1.1-r3.ebuild => setuptools_scm_git_archive-1.1-r4.ebuild} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |