Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 811285

Summary: games-util/lutris-0.5.9_beta1: data_path can't be found at : /usr/lib/python3.9/site-packages/share/lutris
Product: Gentoo Linux Reporter: Daniel Augustin <hossie>
Component: Current packagesAssignee: Gentoo Games <games>
Status: RESOLVED FIXED    
Severity: normal CC: andrewammerlaan, dev
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/22754
Whiteboard:
Package list:
Runtime testing required: ---

Description Daniel Augustin 2021-08-31 19:06:08 UTC
When installing Lutris 0.5.9 Beta1 from the tree, it fails with:

Traceback (most recent call last):
  File "/usr/bin/lutris", line 52, in <module>
    from lutris.gui.application import Application  # pylint: disable=no-name-in-module
  File "/usr/lib/python3.9/site-packages/lutris/gui/application.py", line 46, in <module>
    from lutris.startup import init_lutris, run_all_checks, update_runtime
  File "/usr/lib/python3.9/site-packages/lutris/startup.py", line 12, in <module>
    from lutris.runners.json import load_json_runners
  File "/usr/lib/python3.9/site-packages/lutris/runners/json.py", line 10, in <module>
    os.path.join(datapath.get(), "json"),
  File "/usr/lib/python3.9/site-packages/lutris/util/datapath.py", line 27, in get
    raise IOError("data_path can't be found at : %s" % data_path)
OSError: data_path can't be found at : /usr/lib/python3.9/site-packages/share/lutris

Both 0.5.8.3 and 0.5.8.4 in the tree don't fail like that.

Reproducible: Always




Portage 3.0.20 (python 3.9.6-final-0, default/linux/amd64/17.1/desktop/plasma/systemd, gcc-10.3.0, glibc-2.33-r1, 5.13.12-gentoo x86_64)
=================================================================
System uname: Linux-5.13.12-gentoo-x86_64-Intel-R-_Core-TM-_i9-10850K_CPU_@_3.60GHz-with-glibc2.33
KiB Mem:    32711500 total,   6224732 free
KiB Swap:    1048572 total,   1042052 free
Timestamp of repository gentoo: Sun, 29 Aug 2021 20:30:01 +0000
Head commit of repository gentoo: 938e2c8800435472fd13efccb97ed8d783994e52
Timestamp of repository guru: Sun, 29 Aug 2021 17:21:16 +0000
Head commit of repository guru: 09fe716a13dc9ba8dac2451fdd9db9d01712105a

Timestamp of repository hossie: Fri, 27 Aug 2021 22:51:17 +0000
Head commit of repository hossie: 16c304c838ad23ba2e250e514ca0672a5ffeb912

Timestamp of repository pf4public: Sun, 29 Aug 2021 17:06:38 +0000
Head commit of repository pf4public: 9509f116cb46daea8db405c5611e9cd6d7f90253

Timestamp of repository sattvik: Fri, 27 Aug 2021 22:51:16 +0000
Head commit of repository sattvik: 49704bef882ad41d2a4178bc7cdf6b35b9033eb4

Timestamp of repository steam-overlay: Sun, 29 Aug 2021 17:06:31 +0000
Head commit of repository steam-overlay: 2b2b225cfcf8d49c354072d0327c980677a2d7b4

sh bash 5.1_p8
ld GNU ld (Gentoo 2.36.1 p5) 2.36.1
app-shells/bash:          5.1_p8::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.34.0::gentoo
dev-lang/python:          2.7.18_p11::gentoo, 3.9.6_p1::gentoo
dev-lang/rust:            1.52.1::gentoo
dev-util/cmake:           3.18.5::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.2-r1::gentoo
sys-devel/binutils:       2.36.1-r2::gentoo
sys-devel/gcc:            10.3.0-r2::gentoo
sys-devel/gcc-config:     2.4::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers)
sys-libs/glibc:           2.33-r1::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24

guru
    location: /var/db/repos/guru
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/guru.git
    masters: gentoo

hossie
    location: /var/db/repos/hossie
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/hossie.git
    masters: gentoo

pf4public
    location: /var/db/repos/pf4public
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/pf4public.git
    masters: gentoo

sattvik
    location: /var/db/repos/sattvik
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sattvik.git
    masters: gentoo

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.4/ext-active/ /etc/php/cgi-php7.4/ext-active/ /etc/php/cli-php7.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/vmware-installer"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -march=native"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native"
GENTOO_MIRRORS="https://ftp.gwdg.de/pub/linux/gentoo/ https://ftp.halifax.rwth-aachen.de/gentoo/"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j12"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 bluetooth branding btrfs bzip2 cairo cdda cdr cli crypt cryptsetup cups dbus declarative dri dts dvd dvdr emboss encode exif flac fortran gdbm gif gpm gtk gui iconv icu ipv6 jpeg kde kipi kwallet lcms libglvnd libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf plasma png policykit ppds pulseaudio qml qt5 readline scanner sdl seccomp semantic-desktop spell split-usr ssl startup-notification svg symlink systemd tcpd tiff truetype udev udisks unicode upower usb vdpau vorbis vulkan widgets wifi wxwidgets x264 x265 xattr xcb xml xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt rdrand sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="de" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" QEMU_USER_TARGETS="aarch64 arm" RUBY_TARGETS="ruby26" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS
Comment 1 Andrew Ammerlaan gentoo-dev 2021-10-29 17:39:43 UTC
The issue is here:

/usr/lib/python3.9/site-packages/lutris/util/datapath.py

    launch_path = os.path.realpath("/var/tmp/portage/games-util/lutris-0.5.9_beta1/work/lutris-0.5.9-beta1/share")
    if launch_path.startswith("/usr/local"):
        data_path = "/usr/local/share/lutris"
    elif launch_path.startswith("/usr"):
        data_path = "/usr/share/lutris"
    elif system.path_exists(os.path.normpath(os.path.join("/var/tmp/portage/games-util/lutris-0.5.9_beta1/work/lutris-0.5.9-beta1/share", "share"))):
        data_path = os.path.normpath(os.path.join("/var/tmp/portage/games-util/lutris-0.5.9_beta1/work/lutris-0.5.9-beta1/share", "share/lutris"))
    elif system.path_exists(os.path.normpath(os.path.join(launch_path, "../../share/lutris"))):
        data_path = os.path.normpath(os.path.join(launch_path, "../../share/lutris"))

Our launch_path starts with /var/ and therefore we skip the elif that would lead to the correct data_path: /usr/share/lutris. Changing launch_path to /usr/share fixes the issue.
Comment 2 Andrew Ammerlaan gentoo-dev 2021-10-29 17:43:42 UTC
This sed line in the ebuild is responsible:

sed -i -e "s:sys.path\[0\]:\"${S}/share\":" lutris/util/datapath.py
Comment 3 Larry the Git Cow gentoo-dev 2021-10-29 19:04:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe47523e8c564aac696c97eee7ebc3f0d7b52119

commit fe47523e8c564aac696c97eee7ebc3f0d7b52119
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2021-10-29 18:36:12 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2021-10-29 19:04:11 +0000

    games-util/lutris: remove 0.5.9_beta1
    
    Closes: https://bugs.gentoo.org/811285
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/22754
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 games-util/lutris/Manifest                  |  1 -
 games-util/lutris/lutris-0.5.9_beta1.ebuild | 87 -----------------------------
 2 files changed, 88 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c89bc502532518bf7fc83351b833f066e8065030

commit c89bc502532518bf7fc83351b833f066e8065030
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2021-10-29 18:35:26 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2021-10-29 19:04:10 +0000

    games-util/lutris: add version 0.5.9.1
    
    - We add a patch that avoids:
    importError (Requiring namespace 'Gtk' version '3.0', but '4.0' is already
    loaded)
    
    - And we remove the sed line that makes the application fail to find data_path
    during runtime, the test that this claims to fix works (for me) without this
    sed line anyway.
    Bug: https://bugs.gentoo.org/811285
    
    - Bumped to EAPI 8
    
    - Also update 9999 accordingly
    
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 games-util/lutris/Manifest                         |  1 +
 ....1-avoid-gtk-4.0-already-loaded-testerror.patch | 13 ++++
 games-util/lutris/lutris-0.5.9.1.ebuild            | 80 ++++++++++++++++++++++
 games-util/lutris/lutris-9999.ebuild               | 21 ++----
 4 files changed, 100 insertions(+), 15 deletions(-)