Summary: | www-apps/radicale-3.0.6-r4 uses a probably incorrect DISTUTILS_USE_SETUPTOOLS value | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Henning Schild <henning> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ionen, m.seifert, mgorny, proxy-maint |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/24097 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 812431 | ||
Attachments: | build.log |
Description
Agostino Sarubbo
2021-08-30 12:16:40 UTC
Created attachment 736774 [details]
build.log
build log and emerge --info
ci has reproduced this issue with version 3.0.6-r4 - Updating summary. I'm not sure the QA notice is warranted. From what I can tell, radicale-3.0.6 uses pkg_resources at runtime: https://github.com/Kozea/Radicale/blob/3.0.6/radicale/storage/__init__.py#L39-L40 Shouldn't setuptools be a runtime dependency then? Please let me know if "RDEPENDS+=setuptools" is a good way to shut up that tinderbox. I read https://blogs.gentoo.org/mgorny/2020/10/21/distutils_use_setuptools-qa-spam-and-more-qa-spam/ and am not sure this bug can maybe just be left open. (In reply to Henning Schild from comment #4) > I read > https://blogs.gentoo.org/mgorny/2020/10/21/distutils_use_setuptools-qa-spam- > and-more-qa-spam/ and am not sure this bug can maybe just be left open. You didn't read it at all because the first line of the post says: "Update: the information provided in this post is out of date" I read many things in my life that i did not understand or that are outdated today or have never been "true". Should this bug be fixed? And how would i have to go about it. Maybe provide constructive feedback in the pull request. I understand that @ago might not even know what that QA thing is about and how to go ahead. So i am adding @mgorny to Cc in the hope to learn from him. Is there a way to CC tinderbox to get CI from it for a pull request? I'm totally out of what's happening with python in gentoo atm, but my impression is also that the bugs for DISTUTILS_USE_SETUPTOOLS can be ignored for now. setuptools being deprecated upstream or something. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3ac5197b4812299e0ec7838ec7ff55fb6f7664b8 commit 3ac5197b4812299e0ec7838ec7ff55fb6f7664b8 Author: Henning Schild <henning@hennsch.de> AuthorDate: 2022-02-06 19:43:06 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-02-10 14:19:37 +0000 www-apps/radicale: add missing RDEPENDS on setuptools Closes: https://bugs.gentoo.org/811117 Signed-off-by: Henning Schild <henning@hennsch.de> Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-apps/radicale/radicale-2.1.12-r1.ebuild | 3 ++- www-apps/radicale/radicale-3.0.6-r4.ebuild | 3 ++- www-apps/radicale/radicale-3.1.4.ebuild | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) This check is gone in Gentoo because PEP517 migration changes things around (these bugs are semi-invalid atm). But when it says that =rdepend is wrong, it means upstream doesn't mark that they use setuptools at runtime making it a (possible) unnecessary dep. Not to say that upstream is always right... (In reply to Ionen Wolkens from comment #9) > Not to say that upstream is always right... Which from what I seen juippis grep, is likely the case. So adding the dep may be redundant without PEP517 migration but isn't wrong and will belong there either way. |