Bug 811108 – dev-libs/aws-sdk-cpp: provide -DCUSTOM_MEMORY_MANAGEMENT=OFF mode

• Product: Gentoo Linux
• Status: RESOLVED WONTFIX

[Description Sergei Trofimovich 2021-08-30 11:41:36 UTC]

In https://github.com/NixOS/nix/pull/5188 we found out that enabling shared libraries on dev-libs/aws-sdk-cpp switches Aws::string API from default allocator to AWS allocators and break sys-apps/nix::slyfox package build:

src/libstore/s3-binary-cache-store.cc: In member function
  'virtual nix::StorePathSet nix::S3BinaryCacheStoreImpl::queryAllValidPaths()':
src/libstore/s3-binary-cache-store.cc:431:32: error:
  no matching function for call to 'Aws::S3::Model::ListObjectsRequest::WithBucket(std::string&)'
  430 |                     Aws::S3::Model::ListObjectsRequest()
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  431 |                     .WithBucket(bucketName)
      |                     ~~~~~~~~~~~^~~~~~~~~~~~

WDYT of conditionally or unconditionally providing -DCUSTOM_MEMORY_MANAGEMENT=OFF form of dev-libs/aws-sdk-cpp package?

Example change:

--- a/dev-libs/aws-sdk-cpp/aws-sdk-cpp-1.8.160.ebuild
+++ b/dev-libs/aws-sdk-cpp/aws-sdk-cpp-1.8.160.ebuild
@@ -191,6 +191,7 @@ src_configure() {
                -DENABLE_UNITY_BUILD=$(usex unity-build)
                -DNO_ENCRYPTION=$(usex !ssl)
                -DNO_HTTP_CLIENT=$(usex !http)
+               -DCUSTOM_MEMORY_MANAGEMENT=OFF
        )

        if use test; then

Thanks!

[Comment 1 Sven Eden 2021-11-16 07:02:50 UTC]

A bump of the AWS SDK packages is long overdue anyway.

The default is to use the AWS allocator, so I'd add a USE flag to turn it off.

[Comment 2 Sergei Trofimovich 2022-03-10 17:06:42 UTC]

Does not seem to happen. Will keep the changes needed in overlay.

[Comment 3 Joonas Niilola 2022-03-11 13:16:15 UTC]

Hey, 

Sergey could you do a pull request fixing this? I'll guarantee it will get reviewed and merged.