Bug 810652

Summary:	>=net-dialup/ppp-2.4.8 should support systemd notify
Product:	Gentoo Linux	Reporter:	Steven Davies <gentoo-bugzilla2>
Component:	Current packages	Assignee:	Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Steven Davies 2021-08-27 11:47:59 UTC

From version 2.4.8 ppp has supported a configuration option "up_sdnotify" to alert systemd that the ppp connection has been successfully started. This is configured in Makefile.linux:

# Uncomment the next line to enable Type=notify services in systemd
# If enabled, and the user sets the up_sdnotify option, then
# pppd will not detach and will notify systemd when up.
#SYSTEMD=y

The ebuild should enable this flag when USE=systemd.

The commit: https://github.com/ppp-project/ppp/commit/d34159f417620eb7c481bf53f29fe04c86ccd223

Reproducible: Always

Comment 1 Larry the Git Cow gentoo-dev

2021-08-27 12:13:16 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=62e75843d667106005d59275a569af6a7ae2b294

commit 62e75843d667106005d59275a569af6a7ae2b294
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-08-27 12:02:06 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-08-27 12:13:10 +0000

    net-dialup/ppp: Revbump to implement systemd notification
    
    Thanks-to: Steven Davies <gentoo-bugzilla2@steev.me.uk>
    Closes: https://bugs.gentoo.org/810652
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 net-dialup/ppp/ppp-2.4.9-r5.ebuild | 251 +++++++++++++++++++++++++++++++++++++
 1 file changed, 251 insertions(+)

Comment 2 Steven Davies 2021-08-27 13:04:21 UTC

+	if use systemd ; then
+		einfo "Enabling systemd notification"
+		sed '/SYSTEMD=/s@^#@@' -i pppd/Makefile.linux \
+			die
+	fi


---
Perhaps this should be

|| die

Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2021-08-27 14:20:06 UTC

(In reply to Steven Davies from comment #2)
> +	if use systemd ; then
> +		einfo "Enabling systemd notification"
> +		sed '/SYSTEMD=/s@^#@@' -i pppd/Makefile.linux \
> +			die
> +	fi
> 
> 
> ---
> Perhaps this should be
> 
> || die

Thanks. Fixed.