Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 807985

Summary: app-misc/tracker, app-misc/tracker-miners: Pass -DG_DISABLE_CAST_CHECKS on next bump
Product: Gentoo Linux Reporter: Mart Raudsepp <leio>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Mart Raudsepp gentoo-dev 2021-08-13 12:55:43 UTC
tracker and tracker-miners are applying some things in release build types only, but we use plain type out of necessity (release type appends -O2 style stuff or something).

* -DG_DISABLE_CAST_CHECKS is added to CFLAGS for release builds
* TRACKER_DEBUG debug support is not enabled in release builds, but are force-enabled on plain builds

TRACKER_DEBUG should be enabled for us, so that our users can provide better debug information to upstream or us when something is going on. It's a bit of a mess that upstream is still figuring out. Currently it looks like it's a candidate for a dedicated meson_option instead, which is default enabled and disabling is strongly discouraged.
So we are fine with that being forced on us, because that's what we should have.

However due to this, -DG_DISABLE_CAST_CHECKS isn't passed, which means a bit slower code. It's not worth revbumping for this, so hence this ticket to remember to add this via append-cflags upon next proper full bump instead. pango has an example of this pattern.
Comment 1 Larry the Git Cow gentoo-dev 2022-01-27 02:48:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e777f1cfe398ba3b37fbe6eff1cd0be2dbd22c11

commit e777f1cfe398ba3b37fbe6eff1cd0be2dbd22c11
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-01-27 02:15:16 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-01-27 02:48:08 +0000

    app-misc/tracker-miners: Version bump to 3.2.1
    
    Closes: https://bugs.gentoo.org/807985
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 app-misc/tracker-miners/Manifest                   |   1 +
 .../tracker-miners/tracker-miners-3.2.1.ebuild     | 172 +++++++++++++++++++++
 2 files changed, 173 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4fda7593ca579989ad296e2131bf861bda3112f8

commit 4fda7593ca579989ad296e2131bf861bda3112f8
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-01-27 02:10:28 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-01-27 02:48:08 +0000

    app-misc/tracker: Version bump to 3.2.1
    
    Closes: https://bugs.gentoo.org/807985
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 app-misc/tracker/Manifest                          |   1 +
 ...cker-3.2.1-Add-config-options-for-libsoup.patch |  41 ++++++++
 app-misc/tracker/tracker-3.2.1.ebuild              | 116 +++++++++++++++++++++
 3 files changed, 158 insertions(+)