Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 807664

Summary: media-radio/direwolf-1.5-r1 - dwgpsd.c: error: #error libgps API version might be incompatible.
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Richard Freeman <rich0>
Status: RESOLVED FIXED    
Severity: normal CC: sam, treecleaner
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 806770    
Attachments: emerge-info.txt
emerge-history.txt
environment
etc.portage.tar.bz2
media-radio:direwolf-1.5-r1:20210811-012819.log
temp.tar.bz2

Description Toralf Förster gentoo-dev 2021-08-11 07:17:26 UTC
cc -pipe -march=native -fno-diagnostics-color -O2 -pthread -Igeotranz -D_XOPEN_SOURCE=600 -D_DEFAULT_SOURCE=1 -D_BSD_SOURCE -DUSE_ALSA -DENABLE_GPSD   -c -o dwgpsnmea.o dwgpsnmea.c
cc -pipe -march=native -fno-diagnostics-color -O2 -pthread -Igeotranz -D_XOPEN_SOURCE=600 -D_DEFAULT_SOURCE=1 -D_BSD_SOURCE -DUSE_ALSA -DENABLE_GPSD   -c -o dwgpsd.o dwgpsd.c
dwgpsd.c:61:2: error: #error libgps API version might be incompatible.
   61 | #error libgps API version might be incompatible.
      |  ^~~~~
cc -pipe -march=native -fno-diagnostics-color -O2 -pthread -Igeotranz -D_XOPEN_SOURCE=600 -D_DEFAULT_SOURCE=1 -D_BSD_SOURCE -DUSE_ALSA -DENABLE_GPSD   -c -o dtime_now.o dtime_now.c
make: *** [<builtin>: dwgpsd.o] Error 1

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no_multilib_hardened-j3-20210803-215352

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-11.2.0 *
clang version 12.0.1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/12/bin
/usr/lib/llvm/12
12.0.1
Python 3.9.6
Available Ruby profiles:
  [1]   ruby26 (with Rubygems)
  [2]   ruby30 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.54.0 *
The following VMs are available for generation-2:
1)	IcedTea JDK 3.16.0 [icedtea-bin-8]
*)	AdoptOpenJDK JRE 8.292_p10 [openjdk-jre-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8 
  [2]   openjdk-jre-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.10.4

  HEAD of ::gentoo
commit f318bd73befc20ff7548104b0e5f3d7dc4c9fcb5
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Wed Aug 11 00:36:02 2021 +0000

    2021-08-11 00:35:58 UTC

emerge -qpvO media-radio/direwolf
[ebuild   R   ] media-radio/direwolf-1.5-r1  USE="gps -hamlib -udev"
Comment 1 Toralf Förster gentoo-dev 2021-08-11 07:17:27 UTC
Created attachment 732139 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2021-08-11 07:17:29 UTC
Created attachment 732142 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2021-08-11 07:17:30 UTC
Created attachment 732145 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2021-08-11 07:17:31 UTC
Created attachment 732148 [details]
etc.portage.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2021-08-11 07:17:33 UTC
Created attachment 732151 [details]
media-radio:direwolf-1.5-r1:20210811-012819.log
Comment 6 Toralf Förster gentoo-dev 2021-08-11 07:17:34 UTC
Created attachment 732154 [details]
temp.tar.bz2
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-08-11 23:58:52 UTC
Looks like it needs a bump and additionally needs some changes like https://github.com/wb2osz/direwolf/commit/74cf91cc98a00265af8a5fed9c7d68757953de2f.

Aside: Looks like it might be calling CC directly?
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-08-12 00:00:24 UTC
(In reply to Sam James from comment #7)
> Looks like it needs a bump and additionally needs some changes like
> https://github.com/wb2osz/direwolf/commit/
> 74cf91cc98a00265af8a5fed9c7d68757953de2f.
> 

Oh, the patch is in the newish version (1.6).

> Aside: Looks like it might be calling CC directly?

This is bug 750911 and there's another for AR.
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-27 06:36:47 UTC
ping rich0
Comment 10 Richard Freeman gentoo-dev 2021-10-27 11:01:32 UTC
(In reply to Sam James from comment #9)
> ping rich0

I can potentially bump this but I'm not really in a position to test it right now.  I probably wouldn't have a fix for calling gcc directly, so if we really want to address both it might be simpler just to remove the package.  I'm fine either way and am happy to do the removal if necessay.
Comment 11 Larry the Git Cow gentoo-dev 2021-11-26 05:11:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2451003826e4c1a4807484544e513883ad61810

commit f2451003826e4c1a4807484544e513883ad61810
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-11-26 05:05:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-11-26 05:11:30 +0000

    media-radio/direwolf: add 1.6
    
    Upstream now uses CMake.
    
    Bug: https://bugs.gentoo.org/716708
    Closes: https://bugs.gentoo.org/807664
    Closes: https://bugs.gentoo.org/808513
    Signed-off-by: Sam James <sam@gentoo.org>

 media-radio/direwolf/Manifest                      |  1 +
 media-radio/direwolf/direwolf-1.6.ebuild           | 67 ++++++++++++++++++++++
 .../files/direwolf-1.6-use-standard-doc-dir.patch  | 50 ++++++++++++++++
 3 files changed, 118 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=413d7d28cfa04ff1d59688563ffeb432b7e5d381

commit 413d7d28cfa04ff1d59688563ffeb432b7e5d381
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-11-26 04:46:55 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-11-26 05:11:24 +0000

    media-radio/direwolf: respect AR, CC, and LDFLAGS
    
    Bug: https://bugs.gentoo.org/807664
    Closes: https://bugs.gentoo.org/750911
    Closes: https://bugs.gentoo.org/750914
    Closes: https://bugs.gentoo.org/750935
    Signed-off-by: Sam James <sam@gentoo.org>

 media-radio/direwolf/direwolf-1.5-r1.ebuild        |  4 ++++
 .../direwolf/files/direwolf-1.5-respect-AR.patch   | 22 ++++++++++++++++++++++
 .../files/direwolf-1.5-respect-LDFLAGS.patch       | 22 ++++++++++++++++++++++
 3 files changed, 48 insertions(+)
Comment 12 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-26 05:13:31 UTC
(In reply to Richard Freeman from comment #10)
> (In reply to Sam James from comment #9)
> > ping rich0
> 
> I can potentially bump this but I'm not really in a position to test it
> right now.  I probably wouldn't have a fix for calling gcc directly, so if
> we really want to address both it might be simpler just to remove the
> package.  I'm fine either way and am happy to do the removal if necessay.

I am confident you're able to handle tc-directly ;)

Done now though! It's usually a case of tc-export / emake CC=... if the Makefile already seems to do ~the right thing. If it doesn't, it's usually about changing 'gcc' to $(CC), or CC= to CC?= (or not setting it at all).

The tests pass on the new version so I've gone with that given last-riting felt like a bit of a shame given it's maintained upstream. Let's see if we get any complaints.