Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 803950

Summary: www-client/firefox-90.0.2: fails to build with glibc 2.34 (note: non-constexpr function '__sysconf' cannot be used in a constant expression)
Product: Gentoo Linux Reporter: Sam James <sam>
Component: Current packagesAssignee: Mozilla Gentoo Team <mozilla>
Status: CONFIRMED ---    
Severity: normal CC: canarauc
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=1983703
https://bugs.gentoo.org/show_bug.cgi?id=803953
https://bugzilla.mozilla.org/show_bug.cgi?id=1721326
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 803482    
Attachments: build.log.bz2

Description Sam James archtester gentoo-dev Security 2021-07-25 04:16:24 UTC
37:55.21 /var/tmp/portage/www-client/firefox-90.0.2/work/firefox-90.0.2/js/xpconnect/src/XPCJSContext.cpp:93:25: error: constexpr variable 'kWatchdogStackSize' must be initialized by a constant expression
37:55.21 static constexpr size_t kWatchdogStackSize =
37:55.21                         ^
37:55.21 /var/tmp/portage/www-client/firefox-90.0.2/work/firefox-90.0.2/js/xpconnect/src/XPCJSContext.cpp:94:5: note: non-constexpr function '__sysconf' cannot be used in a constant expression
37:55.21     PTHREAD_STACK_MIN < 32 * 1024 ? 32 * 1024 : PTHREAD_STACK_MIN;
37:55.21     ^
37:55.21 /usr/include/bits/pthread_stack_min-dynamic.h:26:30: note: expanded from macro 'PTHREAD_STACK_MIN'
37:55.21 #   define PTHREAD_STACK_MIN __sysconf (__SC_THREAD_STACK_MIN_VALUE)
37:55.21                              ^
37:55.21 /usr/include/bits/pthread_stack_min-dynamic.h:24:17: note: declared here
37:55.21 extern long int __sysconf (int __name) __THROW;

----
Portage 3.0.20 (python 3.9.6-final-0, default/linux/amd64/17.1/systemd, gcc-11.1.0, glibc-9999, 5.10.51-gentoo-dist-hardened x86_64)
=================================================================
System uname: Linux-5.10.51-gentoo-dist-hardened-x86_64-AMD_Ryzen_7_2700_Eight-Core_Processor-with-glibc2.33.9000
KiB Mem:    16365968 total,   2391896 free
KiB Swap:   16777212 total,  15610364 free
Timestamp of repository gentoo: Fri, 23 Jul 2021 00:45:01 +0000
Head commit of repository gentoo: ac72791ea1b6abaef11b0ddb83185879e8550e5f
sh bash 5.1_p8
ld GNU ld (Gentoo 2.36.1 p3) 2.36.1
ccache version 4.3 [disabled]
app-shells/bash:          5.1_p8::gentoo
dev-lang/perl:            5.34.0-r1::gentoo
dev-lang/python:          3.9.6::gentoo, 3.10.0_beta4::gentoo
dev-lang/rust-bin:        1.53.0::gentoo
dev-util/ccache:          4.3-r3::gentoo
dev-util/cmake:           3.21.0::gentoo
sys-apps/baselayout:      2.7-r3::gentoo
sys-apps/sandbox:         2.24::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.3-r1::gentoo
sys-devel/binutils:       2.36.1-r1::gentoo
sys-devel/gcc:            11.1.0-r2::gentoo
sys-devel/gcc-config:     2.4::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.13::gentoo (virtual/os-headers)
sys-libs/glibc:           9999::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts:

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going=y --with-bdeps=y --deep --complete-graph --usepkg=y"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox multilib-strict news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0"
MAKEOPTS="-j4"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl amd64 bzip2 cli crypt dri fortran gdbm iconv ipv6 libglvnd libtirpc multilib ncurses nls nptl openmp pam pcre readline seccomp split-usr ssl systemd tcpd udev unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby26" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS
Comment 1 Sam James archtester gentoo-dev Security 2021-07-25 04:16:56 UTC
Created attachment 726670 [details]
build.log.bz2
Comment 2 Larry the Git Cow gentoo-dev 2021-08-11 01:38:30 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=704508d6adb23fef2ce6e14a25166848ff3bcbcb

commit 704508d6adb23fef2ce6e14a25166848ff3bcbcb
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2021-08-11 01:19:37 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-08-11 01:38:15 +0000

    www-client/firefox: bump to v91.0
    
    Bug: https://bugs.gentoo.org/803950
    Package-Manager: Portage-3.0.21, Repoman-3.0.3
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/Manifest            |   98 +++
 www-client/firefox/files/firefox-r1.sh |  116 ++++
 www-client/firefox/firefox-91.0.ebuild | 1148 ++++++++++++++++++++++++++++++++
 3 files changed, 1362 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=daeb80d270ac8aa5c8a70002e4a2dff5c976e7c7

commit daeb80d270ac8aa5c8a70002e4a2dff5c976e7c7
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2021-08-10 21:48:54 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-08-11 01:38:15 +0000

    www-client/firefox: bump to v78.13.0 ESR
    
    Bug: https://bugs.gentoo.org/803950
    Package-Manager: Portage-3.0.21, Repoman-3.0.3
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/Manifest               |   97 +++
 www-client/firefox/firefox-78.13.0.ebuild | 1187 +++++++++++++++++++++++++++++
 2 files changed, 1284 insertions(+)
Comment 3 cyrillic 2021-08-11 02:29:09 UTC
Upstream has done some good stuff with firefox-91 :

firefox + rust-1.54 -- works
firefox + python-3.10 -- works
firefox + glibc-2.34 -- works
Comment 4 Cănărău Constantin 2021-08-30 07:52:24 UTC
Firefox 91.0.2 compile fine with glibc-2.34, no patch required, but most of extensions does not work out of the box.
I had to export MOZ_DISABLE_CONTENT_SANDBOX=1 to restore extensions to a working status.

It seems that I am not the only one affected: 
https://forums.gentoo.org/viewtopic-t-1141441-highlight-chromium.html

Nothing else work: firefox-bin, new profile, safe mode or restore defaults settings.
Comment 5 Thomas Deutschmann gentoo-dev Security 2021-08-30 14:11:34 UTC
Just to make this clear: Only >=www-client/firefox-78.13.0 & >=www-client/firefox-91.0 are carrying the linked patches which will be added upstream with there next releases. So www-client/firefox-bin currently doesn't have these patches.

If >=www-client/firefox-78.13.0 or >=www-client/firefox-91.0 doesn't work for you with glibc-2.34 please give us a ping.
Comment 6 Cănărău Constantin 2021-08-31 18:13:05 UTC
Firefox's extensions does not work. 

emerge -pvO sys-libs/glibc www-client/firefox

These are the packages that would be merged, in order:

[ebuild   R   *] sys-libs/glibc-2.34:2.2::gentoo  USE="caps multiarch ssp (static-libs) systemd -audit (-cet) -compile-locales (-crypt) -custom-cflags -doc -gd -headers-only (-multilib) -multilib-bootstrap -nscd -profile (-selinux) -static-pie -suid -systemtap -test (-vanilla)" 0 KiB
[ebuild   R    ] www-client/firefox-91.0.2:0/91::gentoo  USE="clang dbus gmp-autoupdate hwaccel lto openh264 pulseaudio system-av1 system-harfbuzz system-icu system-jpeg system-libevent system-libvpx system-webp -debug -eme-free -geckodriver -hardened -jack -pgo -screencast (-selinux) -sndio -wayland -wifi" L10N="ro -ach -af -an -ar -ast -az -be -bg -bn -br -bs -ca -ca-valencia -cak -cs -cy -da -de -dsb -el -en-CA -en-GB -eo -es-AR -es-CL -es-ES -es-MX -et -eu -fa -ff -fi -fr -fy -ga -gd -gl -gn -gu -he -hi -hr -hsb -hu -hy -ia -id -is -it -ja -ka -kab -kk -km -kn -ko -lij -lt -lv -mk -mr -ms -my -nb -ne -nl -nn -oc -pa -pl -pt-BR -pt-PT -rm -ru -sco -si -sk -sl -son -sq -sr -sv -szl -ta -te -th -tl -tr -trs -uk -ur -uz -vi -xh -zh-CN -zh-TW" 0 KiB

Total: 2 packages (2 reinstalls), Size of downloads: 0 KiB

diff -u /usr/bin/firefox.orig /usr/bin/firefox
--- /usr/bin/firefox.orig	2021-08-31 21:08:33.632344218 +0300
+++ /usr/bin/firefox	2021-08-30 10:45:24.158266864 +0300
@@ -111,6 +111,7 @@
 
 # Don't throw "old profile" dialog box.
 export MOZ_ALLOW_DOWNGRADE=1
+export MOZ_DISABLE_CONTENT_SANDBOX=1
 
 # Run the browser
 exec ${MOZ_PROGRAM} "${@}"

Without MOZ_DISABLE_CONTENT_SANDBOX=1 ublock Origin, Enhancer for Youtube, h264ify does not work.