Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 803071

Summary: app-emulation/virt-viewer-10.0 has an automagic dependencies on x11-libs/vte and app-shells/bash-completion
Product: Gentoo Linux Reporter: Chris Mayo <aklhfex>
Component: Current packagesAssignee: Virtualization Team <virtualization>
Status: UNCONFIRMED ---    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Chris Mayo 2021-07-20 18:28:49 UTC
From meson_options.txt:
option('vte', type: 'feature', value: 'auto', description: 'VTE support')
...
option('bash_completion', type: 'feature', value: 'auto', description: 'bash-completion support')

From meson.build:
vte_min_version='>=0.46.0'
bash_completion_version='2.0'
...
vte_dep = dependency('vte-2.91', version: vte_min_version, required: get_option('vte'))
if vte_dep.found()
  conf_data.set('HAVE_VTE', '1')
endif

bash_completion_dep = dependency('bash-completion', version: '>=' + bash_completion_version, required: get_option('bash_completion'))

if bash_completion_dep.found()
  bash_completion_dir = get_option('bash_completion_dir')


Some other potential tidy-ups:

Could add to emesonargs (equivalent used to be in older ebuilds):
-Dovirt=disabled
although I don't think govirt is available in Gentoo.

Don't think there is a need to repeat the USE flag when the option has the same name e.g.:
$(meson_feature libvirt libvirt)
Comment 1 Chris Mayo 2021-07-20 18:31:53 UTC
Possible dev-lang/perl is no longer a DEPEND.

Might only have been needed for build-aux/syntax-check.mk.
Comment 2 Larry the Git Cow gentoo-dev 2022-04-29 07:50:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1dd22107bb5c42287fb9cb380cf85bcfea2dbd8d

commit 1dd22107bb5c42287fb9cb380cf85bcfea2dbd8d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-29 07:46:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-29 07:50:21 +0000

    app-emulation/virt-viewer: add 11.0
    
    Bug: https://bugs.gentoo.org/803071
    Closes: https://bugs.gentoo.org/835871
    Bug: https://bugs.gentoo.org/734234
    Signed-off-by: Sam James <sam@gentoo.org>

 app-emulation/virt-viewer/Manifest                |  1 +
 app-emulation/virt-viewer/metadata.xml            |  2 +
 app-emulation/virt-viewer/virt-viewer-11.0.ebuild | 68 +++++++++++++++++++++++
 3 files changed, 71 insertions(+)