Summary: | dev-python/pypam-0.5.0: both HOMEPAGE and SRC_URI are broken | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Marco Scardovi (scardracs) <mscardovi> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | floppym, sparky |
Priority: | Normal | Keywords: | PMASKED |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=833297 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Marco Scardovi (scardracs)
2021-07-19 15:05:40 UTC
If upstream is gone, we should think about removing this package from Gentoo. The only reverse dependency is gnome-extra/cinnamon. Could we somehow avoid this dependency in that package? Possible replacement: https://github.com/FirefighterBlu3/python-pam/commit/24bc5ad63c3a9bae61d5f5e8c3f9c2436aad368c (In reply to Mike Gilbert from comment #2) > Possible replacement: > > https://github.com/FirefighterBlu3/python-pam/commit/ > 24bc5ad63c3a9bae61d5f5e8c3f9c2436aad368c Yes, I saw it too but actually does not provide any test suite like the original one. About rev-deps it is used by app-emulation/xen-tools too (I thought it was used by fprintd but actually I was wrong as it uses only pam_wrapper) (In reply to Marco Scardovi (scardracs) from comment #3) > About rev-deps it is used by app-emulation/xen-tools too Hmm, it seems to be in DEPEND in xen-tools. That seems quite strange: why would it need to use PAM during build time? I would guess this is a mistake and it belongs in RDEPEND instead. (In reply to Mike Gilbert from comment #4) > (In reply to Marco Scardovi (scardracs) from comment #3) > > About rev-deps it is used by app-emulation/xen-tools too > > Hmm, it seems to be in DEPEND in xen-tools. That seems quite strange: why > would it need to use PAM during build time? I would guess this is a mistake > and it belongs in RDEPEND instead. It appears strange to me too python-pam[1] seems like this should be the way to go, considering they're working on a drop-in PyPAM replacement. Plus, it's using ctypes bindings instead of platform native bindings, which seems more desirable(?) for a python package. If there were concerns about unit tests, presumably the tests that were added to the PyPAM fork[2] could be submitted to python-pam without too much additional work? From Cinnamon's perspective, it doesn't matter, as it natively supports both PyPAM and python-pam[3] [1] https://github.com/FirefighterBlu3/python-pam [2] https://github.com/scardracs/pypam [3] https://github.com/linuxmint/cinnamon/pull/7327 The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b6f7bbdd84599d901aa0bf4504edef46b6da1beb commit b6f7bbdd84599d901aa0bf4504edef46b6da1beb Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2021-07-19 21:04:31 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2021-07-19 21:06:15 +0000 dev-python/pypam: add distfiles.gentoo.org to SRC_URI Prevents fetch failures for people with broken GENTOO_MIRRORS. Bug: https://bugs.gentoo.org/802927 Signed-off-by: Mike Gilbert <floppym@gentoo.org> dev-python/pypam/pypam-0.5.0-r6.ebuild | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) I found that exist a pypi version too if you prefer https://pypi.org/project/python-pam (In reply to Marco Scardovi (scardracs) from comment #8) > I found that exist a pypi version too if you prefer > https://pypi.org/project/python-pam That is https://github.com/FirefighterBlu3/python-pam Probably preferable to use PyPI over GH as a mirror, but same comments on code still apply. Looks like they haven't tagged a release since 2018. So at the very least we'd want a new tag (or snapshot our own) if we wanted PyPAM compatibility (provided it's actually functional as a drop-in replacement). @floppym seems they have actually added a test suite too https://github.com/FirefighterBlu3/python-pam/tree/master/tests so you should be able to replace it with newer version and drop PyPAM finally. So... It looks like the python-pam dev is (slowly) prepping for a 2.0.0 release. https://github.com/FirefighterBlu3/python-pam/pull/29 However, it looks like it has been refactored a few times, so it no longer has any API compatibility with PyPAM. This is not a problem for Cinnamon. I dug into xen-tools a bit. Looking at all of the source files: > /var/cache/distfiles/xen-4.14.3.tar.gz > /var/cache/distfiles/seabios-1.14.0.tar.gz > /var/cache/distfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz > /var/cache/distfiles/edk2-06dc822d045c2bb42e497487935485302486e151.tar.gz > /var/cache/distfiles/OpenSSL_1_1_1g.tar.gz > /var/cache/distfiles/berkeley-softfloat-b64af41c3276f97f0e181920400ee056b9c88037.tar.gz > /var/cache/distfiles/brotli-666c3280cc11dc433c303d79a83d4ffbdd12cc8d.tar.gz > /var/cache/distfiles/xen-gentoo-patches-23.tar.xz I wasn't seeing any reference to a python file importing "pam" or "PAM". So maybe the dependency on dev-python/pypam is incorrect? Though it does appear to be using the transitive dependency on sys-libs/pam for the C headers. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e063359031eac56cf530a41e9991a9d046d248bd commit e063359031eac56cf530a41e9991a9d046d248bd Author: Sam James <sam@gentoo.org> AuthorDate: 2022-05-28 02:04:47 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-05-28 02:05:00 +0000 profiles: last-rite dev-python/pypam Bug: https://bugs.gentoo.org/833297 Bug: https://bugs.gentoo.org/802927 Signed-off-by: Sam James <sam@gentoo.org> profiles/package.mask | 6 ++++++ 1 file changed, 6 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fca437485e58a32d6d3ece361d8a528f00aa8d82 commit fca437485e58a32d6d3ece361d8a528f00aa8d82 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-06-30 22:20:49 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-06-30 22:20:58 +0000 dev-python/pypam: treeclean Bug: https://bugs.gentoo.org/802927 Bug: https://bugs.gentoo.org/833297 Signed-off-by: Sam James <sam@gentoo.org> dev-python/pypam/Manifest | 1 - dev-python/pypam/files/PyPAM-0.5.0-dealloc.patch | 17 -- .../pypam/files/PyPAM-0.5.0-memory-errors.patch | 128 ------------- dev-python/pypam/files/PyPAM-0.5.0-nofree.patch | 60 ------- .../pypam/files/PyPAM-0.5.0-return-value.patch | 57 ------ dev-python/pypam/files/PyPAM-python3-support.patch | 198 --------------------- dev-python/pypam/files/pypam-0.5.0-stricter.patch | 15 -- dev-python/pypam/metadata.xml | 5 - dev-python/pypam/pypam-0.5.0-r6.ebuild | 45 ----- dev-python/pypam/pypam-0.5.0-r7.ebuild | 45 ----- dev-python/pypam/pypam-0.5.0-r8.ebuild | 40 ----- profiles/package.mask | 6 - 12 files changed, 617 deletions(-) Removed. |