Bug 801637 – net-fs/samba: unconditional dependency on dev-python/subunit?

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sam James 2021-07-12 02:55:54 UTC]

dev-python/subunit seems an unusual unconditional dependency given it's for testing in Python.

Can this be made a conditional BDEPEND for tests? It's caused some issues for users upgrading (observed on both #gentoo and the forums [0]).

[0] https://forums.gentoo.org/viewtopic-p-8633293.html#8633293

[Comment 1 Larry the Git Cow 2021-07-12 03:14:09 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3be57e9c52fe2103d46ff42c8e5b4d048b09217e

commit 3be57e9c52fe2103d46ff42c8e5b4d048b09217e
Author:     Sam James <[e-mail]>
AuthorDate: 2021-07-12 03:12:13 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2021-07-12 03:13:52 +0000

    dev-python/testtools: drop back to EAPI 7 to ease upgrades
    
    This causes an issue because of the following depchain:
            samba -> subunit -> testtools (EAPI 8 only)
    
    While we should try drop the subunit dependency from Samba if possible,
    let's drop testtools back to EAPI 7 temporarily to ease upgrades
    for users, given Samba is a very common package (and even dependency).
    
    Bug: https://bugs.gentoo.org/801637
    Signed-off-by: Sam James <[e-mail]>

 dev-python/testtools/testtools-2.4.0-r2.ebuild | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

[Comment 2 Larry the Git Cow 2021-07-17 09:37:14 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6843e30ac099f62bd722c481acd3a8631d71a6f

commit f6843e30ac099f62bd722c481acd3a8631d71a6f
Author:     Sam James <[e-mail]>
AuthorDate: 2021-07-17 09:36:59 +0000
Commit:     David Seifert <[e-mail]>
CommitDate: 2021-07-17 09:36:59 +0000

    net-fs/samba: conditionalise dependency on dev-python/subunit
    
    Samba seems to configure + build + install fine without subunit
    installed.
    
    Revbumping to allow users to depclean subunit itself but also
    a bunch of assorted Python dependencies. Also, to ensure that
    users upgrading without dynamic deps enabled don't get stuck
    on the "EAPI 8" trap discussed in the bug.
    
    Closes: https://github.com/gentoo/gentoo/pull/21683
    Closes: https://bugs.gentoo.org/801637
    Signed-off-by: Sam James <[e-mail]>
    Signed-off-by: David Seifert <[e-mail]>

 net-fs/samba/{samba-4.13.10.ebuild => samba-4.13.10-r1.ebuild}       | 2 +-
 net-fs/samba/{samba-4.13.9-r1.ebuild => samba-4.13.9-r2.ebuild}      | 2 +-
 net-fs/samba/{samba-4.14.6.ebuild => samba-4.14.4-r2.ebuild}         | 2 +-
 net-fs/samba/{samba-4.14.4-r1.ebuild => samba-4.14.5-r2.ebuild}      | 2 +-
 net-fs/samba/{samba-4.14.5-r1.ebuild => samba-4.14.6-r1.ebuild}      | 2 +-
 net-fs/samba/{samba-4.15.0_rc1.ebuild => samba-4.15.0_rc1-r1.ebuild} | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)