Bug 801181 – sys-cluster/ceph-14.2.21-r1 installs binaries linked to libcrypt.so without depending on virtual/libcrypt

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Aldo 2021-07-08 09:40:57 UTC]

From the build log (attached below):
 * QA Notice: DISTUTILS_USE_SETUPTOOLS is not used when DISTUTILS_OPTIONAL
 * is enabled.
 * QA Notice: Binary files linked to libcrypt.so found
 * But a dependency on virtual/libcrypt is not declared!
 * 
 *   /var/tmp/portage/sys-cluster/ceph-14.2.21-r1/image/usr/lib/python3.8/site-packages/rados.cpython-38-x86_64-linux-gnu.so
 *   /var/tmp/portage/sys-cluster/ceph-14.2.21-r1/image/usr/lib/python3.8/site-packages/rbd.cpython-38-x86_64-linux-gnu.so
 *   /var/tmp/portage/sys-cluster/ceph-14.2.21-r1/image/usr/lib/python3.8/site-packages/cephfs.cpython-38-x86_64-linux-gnu.so
 *   /var/tmp/portage/sys-cluster/ceph-14.2.21-r1/image/usr/lib/python3.8/site-packages/rgw.cpython-38-x86_64-linux-gnu.so

Use flags:
cephfs, cpu_flags_x86_sse, cpu_flags_x86_sse2, cpu_flags_x86_sse3, cpu_flags_x86_sse4_1, cpu_flags_x86_ssse3, fuse, grafana, mgr, **python_targets_python3_8**, radosgw, ssl, tcmalloc, xfs

Side note on the python3_8 dependency: sys-cluster/ceph-14.2.21-r1 does not support python3_9 yet.

Reproducible: Always

Steps to Reproduce:
1. compile =sys-cluster/ceph-14.2.21-r1 with the use flags mentioned in the description (other combinations have not been tested, but python target python3_8 might be essential)
Actual Results:  
build log contains a QA warning that the dependency virtual/libcrypt is missing and the four files mentioned in the QA warning (see description above) link against libcrypt.so

Expected Results:  
If libcrypt.so is linked, the sys-cluster/ceph-14.2.21-r1 ebuild should have a dependency on virtual/libcrypt.

Portage 3.0.20 (python 3.9.5-final-0, default/linux/amd64/17.1/no-multilib, gcc-10.3.0, glibc-2.33-r1, 5.10.27-gentoo-host.0 x86_64)
=================================================================
System uname: Linux-5.10.27-gentoo-host.0-x86_64-Intel-R-_Xeon-R-_CPU_E5405_@_2.00GHz-with-glibc2.33
KiB Mem:    16394476 total,   7940708 free
KiB Swap:   33554364 total,  30230444 free
Timestamp of repository gentoo: Wed, 07 Jul 2021 23:45:01 +0000
Head commit of repository gentoo: 0e0d346ba3ec87c6b8ee39c0d12f8bc70905589f
sh bash 5.1_p8
ld GNU ld (Gentoo 2.35.2 p1) 2.35.2
app-shells/bash:          5.1_p8::gentoo
dev-lang/perl:            5.32.1::gentoo
dev-lang/python:          3.8.10_p2::gentoo, 3.9.5_p2::gentoo
dev-util/cmake:           3.18.5::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/openrc:          0.42.1-r1::gentoo
sys-apps/sandbox:         2.24::gentoo
sys-devel/autoconf:       2.69-r5::gentoo
sys-devel/automake:       1.16.3-r1::gentoo
sys-devel/binutils:       2.35.2::gentoo
sys-devel/gcc:            10.3.0::gentoo
sys-devel/gcc-config:     2.4::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers)
sys-libs/glibc:           2.33-r1::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://lore.xmw.de/gentoo-portage/
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24

fslmude
    location: /var/lib/layman/fslmude
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS=""
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/spool/munin-async/.ssh"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS=""
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--jobs=4 --load-average 0.80"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="https://lore.xmw.de/gentoo/"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en_US de de_DE"
MAKEOPTS="-j8"
PKGDIR="/var/cache/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl amd64 bzip2 cacert cli crypt dri fortran gdbm iconv ipv6 libglvnd libtirpc mmx ncurses nls nptl openmp pam pcre readline seccomp split-usr sse sse2 ssl tcpd unicode vim-syntax xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3 sse4_1 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" QEMU_SOFTMMU_TARGETS="x86_64 i386" QEMU_USER_TARGETS="x86_64 i386" RUBY_TARGETS="ruby26" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS

[Comment 1 Aldo 2021-07-08 09:45:29 UTC]

Created attachment 722680 [details]
sys-cluster/ceph-14.2.21-r1 build log

compressed in order to get below 1000KB

[Comment 2 Georgy Yakovlev 2021-07-08 10:11:32 UTC]

it may be false alarm similar to how it happened in libxml2

https://bugs.gentoo.org/798942

TLDR: ldflags order matters. as-needed has to come before -l flags, not after.

but idk, needs checking.

[Comment 3 Georgy Yakovlev 2021-07-08 10:15:02 UTC]

/usr/bin/x86_64-pc-linux-gnu-gcc -shared -L/var/tmp/portage/sys-cluster/ceph-14.2.21-r1/work/ceph-14.2.21_build/lib -g1 /var/tmp/portage/sys-cluster/ceph-14.2.21-r1/work/ceph-14.2.21_build/lib/cython_modules/temp.linux-x86_64-3.8/var/tmp/portage/sys-cluster/ceph-14.2.21-r1/work/ceph-14.2.21_build/src/pybind/rgw/rgw.o -L/usr/lib64 -L/usr/lib64 -lrados -lrgw -lcrypt -lpthread -ldl -lutil -lm -lm -o /var/tmp/portage/sys-cluster/ceph-14.2.21-r1/work/ceph-14.2.21_build/lib/cython_modules/lib.3/rgw.cpython-38-x86_64-linux-gnu.so
make[2]: Leaving directory '/var/tmp/portage/sys-cluster/ceph-14.2.21-r1/work/ceph-14.2.21_build'

no, it actually calls -lcrypt

[Comment 4 Aldo 2021-07-08 15:26:31 UTC]

Oh, upon investigating a tiny bit more I just saw that the testing ebuild for ceph-14.2.22 (see https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-cluster/ceph/ceph-14.2.22.ebuild) does already contain the dependency on virtual/libcrypt, as do those for ceph-1{5,6}, which would resolve this bug as soon as 14.2.22 is marked as stable.

[Comment 5 Larry the Git Cow 2021-07-10 18:54:22 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4248f26a9bf3279cbca095be2e1d42e57b217c10

commit 4248f26a9bf3279cbca095be2e1d42e57b217c10
Author:     Sam James <[e-mail]>
AuthorDate: 2021-07-10 18:49:39 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2021-07-10 18:49:39 +0000

    sys-cluster/ceph: add missing libcrypt dependency
    
    Closes: https://bugs.gentoo.org/801181
    Signed-off-by: Sam James <[e-mail]>

 sys-cluster/ceph/{ceph-14.2.21-r1.ebuild => ceph-14.2.21-r2.ebuild} | 1 +
 sys-cluster/ceph/{ceph-15.2.12-r1.ebuild => ceph-15.2.12-r2.ebuild} | 1 +
 2 files changed, 2 insertions(+)