Bug 800290

Summary:	dev-libs/marisa-0.2.6 DISTUTILS_USE_SETUPTOOLS is not used when DISTUTILS_OPTIONAL
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Arfrever Frehtes Taifersar Arahesis <arfrever.fta>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cjk, python
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=800147
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	812431
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2021-07-04 09:20:42 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/marisa-0.2.6 uses a probably incorrect DISTUTILS_USE_SETUPTOOLS value.
Discovered on: amd64 (internal ref: tinderbox)

Comment 1 Agostino Sarubbo gentoo-dev

2021-07-04 09:20:45 UTC

Created attachment 721498 [details]
build.log

build log and emerge --info

Comment 2 Arfrever Frehtes Taifersar Arahesis 2021-07-06 11:26:42 UTC

>  * QA Notice: DISTUTILS_USE_SETUPTOOLS is not used when DISTUTILS_OPTIONAL
>  * is enabled.


In all ebuilds:
DISTUTILS_USE_SETUPTOOLS="no"


QA notice was introduced by:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3156d07f30384ec0669d2fdda1a46a83431781e5
> +		if [[ ${DISTUTILS_USE_SETUPTOOLS} != bdepend ]]; then

Maybe it would be better to use this check:

if [[ ! ${DISTUTILS_USE_SETUPTOOLS} =~ ^(no|bdepend)$ ]] ; then

Comment 3 Arfrever Frehtes Taifersar Arahesis 2022-01-27 02:53:13 UTC

This QA check, which was possibly slightly suboptimal as mentioned above, was recently deleted on 2022-01-16:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f344326fa3c3653d85acf12bf053bfd98f354c56


We can still delete unused DISTUTILS_USE_SETUPTOOLS variable in this package.

Comment 4 Larry the Git Cow gentoo-dev

2022-01-29 15:20:06 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8cf2efc4b563886026de93809d9d7abff232e706

commit 8cf2efc4b563886026de93809d9d7abff232e706
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2022-01-20 05:00:00 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2022-01-29 15:19:02 +0000

    dev-libs/marisa: Delete unused DISTUTILS_USE_SETUPTOOLS.
    
    Closes: https://bugs.gentoo.org/800290
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 dev-libs/marisa/marisa-0.2.5.ebuild | 5 ++---
 dev-libs/marisa/marisa-0.2.6.ebuild | 1 -
 dev-libs/marisa/marisa-9999.ebuild  | 1 -
 3 files changed, 2 insertions(+), 5 deletions(-)