Summary: | app-emacs/helm: emacs-helm.sh is installed but is non-functional | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | akater <nuclearspace> |
Component: | Current packages | Assignee: | GNU Emacs project <gnu-emacs> |
Status: | RESOLVED FIXED | ||
Severity: | major | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
app-emacs/helm: Fix path of autoloads file in emacs-helm.sh
app-emacs/helm: Don't check for autoload file in emacs-helm.sh |
Description
akater
2021-07-03 13:14:08 UTC
It will be true at least for helm-3.8.0 but it might not be true for helm-3.6.0 which is currently the latest in the tree so I changed the importance to “enhancement”. No, unfortunately it's broken in 3.6.0 proper, sorry for the confusion. Created attachment 721267 [details, diff]
app-emacs/helm: Fix path of autoloads file in emacs-helm.sh
Please test if attached patch fixes the problem.
The emacs-helm.sh script does start now but • How is user supposed to find it? • Why is altering the script preferrable to creating symlinks? I'd like to understand Gentoo's best practices. Created attachment 721642 [details, diff]
app-emacs/helm: Don't check for autoload file in emacs-helm.sh
We can install the script in /usr/bin if you prefer.
About modifying the script, IMHO a better way to do that check would be with locate-library in the elisp code (helm-cfg.el), which would search the load-path. Using find to sniff around in some random locations doesn't make much sense IMHO, and I won't add symlinks to work around the resulting breakage. Besides, placing a symlink to an elisp file in /usr/bin is out of the question (and the same reasoning applies to ${SITEETC}).
Thinking about it, for the Gentoo pacakge it may be easier to remove that test altogether, because the AUTO_FILE variable isn't even used, and it's guaranteed that the autoloads file is installed.
Updated patch is attached.
This is much better, I'll use that. Thank you. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1162299d4546ec32ef26bf78816989761b591f4c commit 1162299d4546ec32ef26bf78816989761b591f4c Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2021-07-03 17:16:15 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2021-07-04 12:39:25 +0000 app-emacs/helm: Don't check for autoload file in emacs-helm.sh Closes: https://bugs.gentoo.org/800177 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Ulrich Müller <ulm@gentoo.org> .../helm/files/helm-3.6.0-no-autoload-check.patch | 24 ++++++++++++++++++++++ .../{helm-3.6.0.ebuild => helm-3.6.0-r1.ebuild} | 6 +++--- 2 files changed, 27 insertions(+), 3 deletions(-) |