Summary: | app-portage/gentoolikt-dev echangelog does not understand GECOS | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Eric Shattow <lucent> |
Component: | [OLD] Development | Assignee: | Aron Griffis (RETIRED) <agriffis> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | mr_bones_ |
Priority: | High | ||
Version: | 2004.3 | ||
Hardware: | x86 | ||
OS: | Linux | ||
URL: | http://grungie.code511.com/MHW_11_Doc/gecos_read.html | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Eric Shattow
2005-01-29 17:33:01 UTC
I vote no on this one. Parsing GECOS is a losing battle. I believe echangelog will use ECHANGELOG_USER if set so any developer who wants to "protect" their information can just set that. All GECOS styles I have seen use the person's name as the first part, and comma seperated. Everything in the passwd entry for name field should be parsed up to the first comma, if there is one. That doesn't seem like a losing battle to me. This should be trivial to implement. > This should be trivial to implement.
Great, please attach the patch
> Great, please attach the patch
I might set the incoming field seperator from awk to be a comma, and take the first field. Is there a better way?
Fixed in cvs. Your suggestion doesn't make any sense in a Perl program, btw, and certainly doesn't constitute a patch. Next time please make an effort. |