Bug 799440

Summary:	sci-electronics/puff-20181104 calls ld directly
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Thomas Beierlein <tomjbe>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sci-electronics
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	243502
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2021-07-01 06:42:12 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-electronics/puff-20181104 calls ld directly.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GCC-11: https://gcc.gnu.org/gcc-11/porting_to.html
As per QA policy, toolchain tools must not be called directly because they can cause issue in cross-compiling and because is not possible use a different LD implementation (like llvm-link). To reproduce, please use sys-devel/gcc-config[-native-symlinks], sys-devel/binutils-config[-native-symlinks].

Comment 1 Agostino Sarubbo gentoo-dev

2021-07-01 06:42:15 UTC

Created attachment 720435 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2021-07-01 06:42:17 UTC

Possible context of error(s):

ppasx.sh: line 10: ld: command not found

Comment 3 Thomas Beierlein gentoo-dev

2021-07-03 15:44:41 UTC

Not sure if policy is really relevant in this case as the Free Pascal Compiler which is used here does not even build with the GNU gold linker. Anyway....

Fixing was a little bit nasty as fpc generates a linker script during compile. So we have to patch the Makefile so that it later patches these linker script with the actual linker command. See the patches in FILESDIR for details.

Comment 4 Larry the Git Cow gentoo-dev

2021-07-03 15:47:51 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23e6cad3c576c32f97ad857da284e51a88ae9da1

commit 23e6cad3c576c32f97ad857da284e51a88ae9da1
Author:     Thomas Beierlein <tomjbe@gentoo.org>
AuthorDate: 2021-07-03 15:46:30 +0000
Commit:     Thomas Beierlein <tomjbe@gentoo.org>
CommitDate: 2021-07-03 15:47:36 +0000

    sci-electronics/puff: Do not call 'ld' directly
    
    Closes: https://bugs.gentoo.org/799440
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Thomas Beierlein <tomjbe@gentoo.org>

 .../puff/files/puff-20100127-Makefile.patch         | 19 +++++++++++++++++++
 .../puff/files/puff-20181104-Makefile.patch         | 21 +++++++++++++++++++++
 sci-electronics/puff/puff-20100127-r1.ebuild        | 10 ++++------
 sci-electronics/puff/puff-20181104.ebuild           |  9 ++++-----
 4 files changed, 48 insertions(+), 11 deletions(-)