Summary: | x11-plugins/gkrellm-leds-0.8.2-r1 - /.../ld: cannot find @GK_LDFLAGS@: No such file or directory | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | sam, t |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/24729 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 765709 | ||
Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tar.bz2 logs.tar.bz2 temp.tar.bz2 x11-plugins:gkrellm-leds-0.8.2-r1:20210628-230237.log |
Description
Toralf Förster
2021-06-29 07:21:35 UTC
Created attachment 720006 [details]
emerge-info.txt
Created attachment 720009 [details]
emerge-history.txt
Created attachment 720012 [details]
environment
Created attachment 720015 [details]
etc.portage.tar.bz2
Created attachment 720018 [details]
logs.tar.bz2
Created attachment 720021 [details]
temp.tar.bz2
Created attachment 720024 [details]
x11-plugins:gkrellm-leds-0.8.2-r1:20210628-230237.log
I'm looking at moving the ebuild from EAPI 6 -> 8, and hoping I could fix this in the meantime. Looking at the Makefile.in, there are three variables defined: --- GKM_CFLAGS = @GKM_CFLAGS@ GKM_EXTRA_SRCS = @GKM_EXTRA_SRCS@ GKM_LDFLAGS = @GKM_LDFLAGS@ --- and further down they are used like this: --- gkleds_la_CFLAGS = -Wall -O2 -I../pixmaps @X_CFLAGS@ @GTK_CFLAGS@ @GKM_CFLAGS@ gkleds_la_LIBADD = @X_PRE_LIBS@ @X_LIBS@ @X_EXTRA_LIBS@ @GTK_LIBS@ @GKM_EXTRA_SRCS@ gkleds_la_LDFLAGS = -module -avoid-version @GK_LDFLAGS@ --- Do you think it's "just" a typo and @GK_FLAGS@ should've been @GKM_FLAGS@? After the src_configure phase, grepping for GK_FLAGS gives just two hits: $ grep -R GK_LDFLAGS src/Makefile.am:gkleds_la_LDFLAGS = -module -avoid-version @GK_LDFLAGS@ src/Makefile.in:gkleds_la_LDFLAGS = -module -avoid-version @GK_LDFLAGS@ > Do you think it's "just" a typo and @GK_FLAGS@ should've been @GKM_FLAGS@?
I mean of course @GK_LDFLAGS@ and @GKM_LDFLAGS@
I think it's got to be - @FOO@ _has_ to be subtituted in or it's just meaningless junk (like we see in this bug). The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d557df31533026ecba7c8c4b4a4fd8ee2d136a1 commit 1d557df31533026ecba7c8c4b4a4fd8ee2d136a1 Author: Thomas Bracht Laumann Jespersen <t@laumann.xyz> AuthorDate: 2022-03-23 14:52:59 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-04-07 02:20:46 +0000 x11-plugins/gkrellm-leds: update EAPI 6 -> 8 Besides the EAPI bump, there's a bug for the referenced bug. The issue seems to be simply a typo in src/Makefile.am resulting in a variable @GK_LDFLAGS@ not being replaced appropriately. Closes: https://bugs.gentoo.org/799176 Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz> Closes: https://github.com/gentoo/gentoo/pull/24729 Signed-off-by: Sam James <sam@gentoo.org> .../files/gkrellm-leds-0.8.2-r2-ldflags-typo.patch | 12 ++++++++ .../gkrellm-leds/gkrellm-leds-0.8.2-r2.ebuild | 36 ++++++++++++++++++++++ 2 files changed, 48 insertions(+) |