Bug 798945

Summary:	dev-libs/newt: missing virtual/libcrypt:= dependency
Product:	Gentoo Linux	Reporter:	Alexander Tsoy <alexander>
Component:	Current packages	Assignee:	Ben Kohler <bkohler>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=798942
Whiteboard:	Fails because of LDFLAGS ordering issue with as-needed; need to swap order in Makefile
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	798963

Description Alexander Tsoy 2021-06-27 19:49:39 UTC

Messages generated by process 20591 on 2021-06-27 22:33:41 MSK for package dev-libs/newt-0.52.21-r1:

QA: other
Binary files linked to libcrypt.so found
But a dependency on virtual/libcrypt is not declared!

  /var/tmp/portage/dev-libs/newt-0.52.21-r1/image/usr/lib/python3.9/site-packages/_snack.so

Please add virtual/libcrypt:= dependency
Gentoo bug: https://bugs.gentoo.org/699422
See: https://wiki.gentoo.org/wiki/Project:Toolchain/libcrypt_implementation

Comment 1 Alexander Tsoy 2021-06-27 20:03:02 UTC

Probably the same problem as in bug #798942

Comment 2 Sam James archtester

2021-06-28 01:17:52 UTC

(In reply to Alexander Tsoy from comment #1)
> Probably the same problem as in bug #798942

Yep, I think we can get away with swapping the order of LDFLAGS and P*: https://pagure.io/newt/blob/master/f/Makefile.in#_85.

Comment 3 Larry the Git Cow gentoo-dev

2021-07-14 04:53:21 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5570cc427432efe0d2dec2f1054ee37ceb08492a

commit 5570cc427432efe0d2dec2f1054ee37ceb08492a
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-07-14 04:29:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-07-14 04:52:56 +0000

    dev-libs/newt: fix libcrypt QA warning false positive
    
    * Fix LDFLAGS ordering (respect as-needed, similar to libxml2)
    * Fix configure with non-Bash (dash here)
    
    Closes: https://bugs.gentoo.org/798945
    Signed-off-by: Sam James <sam@gentoo.org>

 .../newt-0.52.21-fix-non-POSIX-backticks.patch     | 27 +++++++++++++++++++
 .../newt-0.52.21-makefile-LDFLAGS-ordering.patch   | 30 ++++++++++++++++++++++
 dev-libs/newt/newt-0.52.21-r1.ebuild               | 14 ++++++----
 3 files changed, 66 insertions(+), 5 deletions(-)