| Summary: | New USER_ALLOWED_FLAGS variable | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Kaiting Chen <Phoenixfire159> |
| Component: | New packages | Assignee: | SpanKY <vapier> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
strip-flags is to produce a sane system if the user is allowed to control the idea of a 'sane system', bad things can (and do) happen Yeah, but that's the user's own fault. I mean, just because you implement this doesn't mean that everyone's going to use it. It's just annoying having to update the eclass every time I emerge --sync. If we could overlay eclasses, that would be great to. But as things stand, I don't think it would cause any problems for this to be implemented, and with a warning in /etc/make.conf.example such as: "This can and probably will break your system." And another thing. Fomit-frame-pointer rarely causes problems. In fact, I have my entire system compiled with that flag, (except for glibc and the like, which explicitly filter it out). Lots of ebuilds just call strip-flags just for the heck of it, which unfortunately, filters out fomit-frame-pointer. i dont care, it's not going to happen hrm, neglected to close the bug last time You can overlay eclasses, btw. |
The flag-o-matic eclass, when using the function strip-flags, strips all flags that aren't in ALLOWED_FLAGS (and UNSTABLE_FLAGS if running a ~ARCH). Sometimes, though, a user will really want to use a flag that they know is stable for their system, or one that speeds up compilation but does not change actually code, or something else that they just want to use regardless. I think there should be a USER_ALLOWED_FLAGS variable that they could put in /etc/make.conf. Then, we could add the line somewhere in the strip-flags function: ALLOWED_FLAGS="${USER_ALLOWED_FLAGS} ${ALLOWED_FLAGS}" That way, if a user really wanted to use a flag, it would not be stripped. Reproducible: Always Steps to Reproduce: