Bug 796335

Summary:	sys-apps/systemd: systemd-cryptenroll-248.3 aborts when creating recovery key
Product:	Gentoo Linux	Reporter:	Martin Bednar <martin>
Component:	Current packages	Assignee:	Gentoo systemd Team <systemd>
Status:	RESOLVED OBSOLETE
Severity:	normal	CC:	mscardovi, sam
Priority:	Normal
Version:	unspecified
Hardware:	AMD64
OS:	Linux
URL:	https://github.com/systemd/systemd/issues/19203
Whiteboard:
Package list:		Runtime testing required:	---

Description Martin Bednar 2021-06-16 11:25:14 UTC

systemd-248.3

command:
systemd-cryptenroll /dev/disk/by-uuid/d73ec2dd-d0ed-4c06-962b-a9b591755ed6  --recovery-key
🔐 Please enter current passphrase for disk /dev/disk/by-uuid/d73ec2dd-d0ed-4c06-962b-a9b591755ed6: ********                
*** buffer overflow detected ***: terminated
Aborted (core dumped)

coredump:

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49
49      ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49
#1  0x00007fa3c66b3536 in __GI_abort () at abort.c:79
#2  0x00007fa3c670c757 in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7fa3c68183ca "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:155
#3  0x00007fa3c679d232 in __GI___fortify_fail (msg=msg@entry=0x7fa3c6818370 "buffer overflow detected") at fortify_fail.c:26
#4  0x00007fa3c679bb70 in __GI___chk_fail () at chk_fail.c:28
#5  0x00007fa3c679d1f5 in __explicit_bzero_chk (dst=<optimized out>, len=<optimized out>, dstlen=<optimized out>) at explicit_bzero_chk.c:34
#6  0x00007fa3c6d19500 in make_recovery_key () from /lib/systemd/libsystemd-shared-248.so
#7  0x000056405bbd8287 in enroll_recovery ()
#8  0x000056405bbd6ec9 in main ()

Reproducible: Always

Comment 1 Martin Bednar 2021-06-16 11:28:05 UTC

Found the upstream issue:
https://github.com/systemd/systemd/issues/19203

Comment 2 Mike Gilbert gentoo-dev

2021-06-17 15:40:57 UTC

The fix for this makes a lot of changes, so I probably will not attempt to backport it myself. If upstream tags 248.4 with the fix, we can pick it up then.