Bug 79430 – mod_auth_pgsql needs new revision using apache-module.eclass

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Michael Stewart (vericgar) (RETIRED) 2005-01-25 03:18:38 UTC]

As of apache-2.0.52-r3 and -1.3.33-r1 apache uses new paths and configurations. We have created eclasses to make apache module maintainers life's easier. See http://dev.gentoo.org/~vericgar/doc/apache-package-refresh.html on how to update your ebuild to use the new eclass. When we unmask the new apache revision, mod_auth_pgsql will break if it isn't adapted to the new eclass.

[Comment 1 Masatomo Nakano (RETIRED) 2005-02-19 16:30:07 UTC]

added ebuilds using apache-module.eclass

[Comment 2 Benedikt Böhm (RETIRED) 2005-02-25 09:20:46 UTC]

the ebuild uses the eclass inappropriately, please see the attatched patch

further it would be nice if mod_auth_pgsql ships a default config (example)

[Comment 3 Benedikt Böhm (RETIRED) 2005-02-25 09:21:09 UTC]

Created attachment 52133 [details, diff]
mod_auth_pgsql.patch

[Comment 4 Masatomo Nakano (RETIRED) 2005-02-25 10:05:16 UTC]

thank you for your advise.

But I'm not sure about this.
In the apache herd's page( http://dev.gentoo.org/~vericgar/doc/apache-package-refresh.html ), 
APXS2_ARGS is defined in src_compile() function, but it's defined outside on yours.

Which is better?

[Comment 5 Benedikt Böhm (RETIRED) 2005-02-25 13:29:17 UTC]

the example makes use of the `use` function which should not be used in global scope, that's why it's placed in the function, but in mod_auth_pgsql there is no need to place it into local scope

[Comment 6 Michael Stewart (vericgar) (RETIRED) 2005-02-25 19:10:47 UTC]

hollow has hit it right on the nose.
The example in that documentation is showing a more complex package, that needs a custom APXSn_ARGS depending on whether the ssl USE-flag is set. If you don't have this complex case, then APXSn_ARGS should be defined globally for a cleaner ebuild. I recommend Hollow's patchs. He knows what he's doing :)

[Comment 7 Masatomo Nakano (RETIRED) 2005-02-26 09:14:04 UTC]

ok. I thought there was another reason why it is declared in src_compile function.

I've applied the patch and modified ebuild to install html documents which include example config file.

Thanks!