| Summary: | media-video/mplayer-1.0_pre6 ebuild and "libdv" support | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | TGL <tom.gl> |
| Component: | New packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
mplayer-1.0_pre6--dv_use_flag.patch
mplayer-1.0_pre6--dv_use_flag-bis.patch |
||
Created attachment 49359 [details, diff]
mplayer-1.0_pre6--dv_use_flag.patch
Created attachment 49361 [details, diff]
mplayer-1.0_pre6--dv_use_flag-bis.patch
This version is in case you decide to drop the dv->encode USE flag dependency.
made the changes which your first patch suggested. thanks. |
Some small issues with the mplayer-1.0_pre6 ebuild regarding libdv support: - the "dv" local USE flag that is used in RDEPEND doesn't have its use;local.desc entry (or should the flag become global since it's also used by media-libs/libquicktime, media-video/mjpegtools and media-video/transcode?) - it is not declared in IUSE. - the flag doesn't enforce the --{enable,disable}-libdv configure option, thus the lib is autodetect (seen it because my last "emerge depclean" removed libdv and thus broke mplayer dynamic linking). I will attach a small patch for the 2 last issues. It assumes that libdv support is only required if USE=encode and should be disabled otherwise, with the same logic that is in RDEPEND. But looking at the "./configure --help", i see they speak of both encoding and decoding support for libdv, so maybe that should be changed and "dv" should not depend on "encode". I don't know for sure since i don't use it, i let you decide.