Bug 79312

Summary:	media-video/gsubedit buffer overflow in lines longer than 20 chars
Product:	Gentoo Linux	Reporter:	Lluís Batlle i Rossell <viric>
Component:	New packages	Assignee:	Gentoo Media-video project <media-video>
Status:	RESOLVED FIXED
Severity:	normal	CC:	phosphan, rockoo
Priority:	High	Keywords:	Inclusion
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	95215
Attachments:	Solves the 20chars long bug.

Description Lluís Batlle i Rossell 2005-01-24 04:21:06 UTC

There is a limit to '20 chars per line' in the code for writting the subtitle. If some line is written with more than 20 chars, appears a problem about "looking for the null string end". So, a lot of strings get rubbish after them.

I'll send a patch for solving that.

Comment 1 Lluís Batlle i Rossell 2005-01-24 04:24:05 UTC

Created attachment 49355 [details, diff]
Solves the 20chars long bug.

Copy that file to the "files" directory, and set the 'unpack' function to that,
in the ebuild:
src_unpack() {
    unpack ${A}
    epatch ${FILESDIR}/gsubedit-0.4pre1-bufferlen.patch
    cd ${S}
    epatch ${FILESDIR}/crashes.patch
}

Comment 2 Thierry Carrez (RETIRED) gentoo-dev

2005-01-27 08:15:30 UTC

This is not a security issue, right ? Reassigning...

If it's indeed a vulnerability, please reassign to us with a note explaining how this can be exploited...

Comment 3 Daniel Webert 2005-06-06 06:46:42 UTC

can we add the patch to close this bug and stablize the pkg ...

Comment 4 Daniel Webert 2005-08-04 10:27:06 UTC

can we plz fix this - 6 months old w/ exiting patch

Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev

2005-12-17 17:40:28 UTC

Applied, thanks.