Bug 789741

Summary:	games-action/teeworlds-0.7.5 has outdated translation data
Product:	Gentoo Linux	Reporter:	Esteve Varela Colominas <esteve.varela>
Component:	Current packages	Assignee:	Gentoo Games <games>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ionen, sam
Priority:	Normal	Keywords:	EBUILD
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	updated ebuild

Description Esteve Varela Colominas 2021-05-12 19:59:27 UTC

Version 0.7.5 ships with commit 4ed69dd7497ca6e04bab0b042f137bf97f3c5d0a, as can be seen here: https://github.com/teeworlds/teeworlds/tree/0.7.5/datasrc

However, the ebuild includes commit 4ba6f824e9c34565e61340d25bc8c3cc004d40fb instead.

I suggest using the source release archives, to avoid having to pull down several separate archives from github, and causing desyncs like this. For 0.7.5 it can be found here: https://github.com/teeworlds/teeworlds/releases/download/0.7.5/teeworlds-0.7.5-src.tar.gz

Comment 1 Esteve Varela Colominas 2021-05-12 20:22:06 UTC

Created attachment 707745 [details]
updated ebuild

Here's an ebuild that sources everything from the -src.tar.gz archive, as well as some minor cleanups, and the addition of the libsdl2 dependency.

Comment 2 Sam James archtester

2021-05-13 19:11:04 UTC

Thank you!

Comment 3 Larry the Git Cow gentoo-dev

2021-05-13 20:33:28 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4d3b79187de38d8bc6f22c38943e56a5cd3eef65

commit 4d3b79187de38d8bc6f22c38943e56a5cd3eef65
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-05-13 19:11:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-05-13 20:33:07 +0000

    games-action/teeworlds: fix outdated translation data
    
    Thanks-to: Esteve Varela Colominas <esteve.varela@gmail.com>
    Closes: https://bugs.gentoo.org/789741
    Signed-off-by: Sam James <sam@gentoo.org>

 games-action/teeworlds/Manifest                  |  5 +--
 games-action/teeworlds/teeworlds-0.7.5-r1.ebuild | 47 +++++++-----------------
 2 files changed, 14 insertions(+), 38 deletions(-)

Comment 4 Sam James archtester

2021-05-13 20:34:35 UTC

I had to manually change some bits - S wasn't right and 'convert' wasn't working without an extra nudge as to which icon to extract. Thanks!

Comment 5 Esteve Varela Colominas 2021-05-14 01:02:39 UTC

I could've sworn it worked fine on my machine. Now I'm left wondering how on earth.
Oh well, thanks for adding it!