Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 788190

Summary: generate then add VERSION_ID or BUILD_ID to os-release on emerging sys-apps/baselayout
Product: Gentoo Linux Reporter: pmn <darwinskernel>
Component: Current packagesAssignee: William Hubbs <williamh>
Status: RESOLVED FIXED    
Severity: normal CC: darwinskernel, gentoo
Priority: Normal    
Version: unspecified   
Hardware: AMD64   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description pmn 2021-05-04 18:20:00 UTC 
according to BOOT_LOADER_SPECIFICATION[1] EFI Unified Kernel Images require VERSION_ID in their .osrel section.

some tools like bootctl(1) will be content with build_id also [2].

[1] https://systemd.io/BOOT_LOADER_SPECIFICATION/#type-2-efi-unified-kernel-images
[2] https://github.com/systemd/systemd/blob/8fc1efa88fb935ab4357fa39ed71ccb70df55d7e/src/shared/bootspec.c#L320

Reproducible: Always

Steps to Reproduce:
grep VERSION_ID /etc/os-release
Actual Results:  
will return empty hand

Expected Results:  
VERSION_ID=some_id
Comment 1 Larry the Git Cow gentoo-dev 2021-09-24 23:08:32 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/baselayout.git/commit/?id=57c250e24c70f8f9581860654cdec0d049345292

commit 57c250e24c70f8f9581860654cdec0d049345292
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2021-09-24 23:05:36 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2021-09-24 23:05:36 +0000

    generate /usr/lib/os-release dynamically
    
    This allows the os name and version to be dynamic.
    
    Bug: https://bugs.gentoo.org/788190
    
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 Makefile             |  3 +++
 etc.BSD/os-release   |  7 -------
 etc.Linux/os-release |  7 -------
 make_os_release      | 15 +++++++++++++++
 4 files changed, 18 insertions(+), 14 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2021-09-24 23:15:29 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ce50fe689addf7ebc8861af8b290145bb741b6c

commit 4ce50fe689addf7ebc8861af8b290145bb741b6c
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2021-09-24 23:14:03 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2021-09-24 23:15:11 +0000

    sys-apps/baselayout:
    
    Move handling of the os-release file upstream.
    
    Closes: https://bugs.gentoo.org/788190
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 sys-apps/baselayout/baselayout-9999.ebuild | 5 -----
 1 file changed, 5 deletions(-)