Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 787581

Summary: net-libs/gtk-vnc-1.2.0[introspection,-vala]: Unknown variable "with_vala"
Product: Gentoo Linux Reporter: matoro <matoro_gentoo>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: Dan.Johansson, dmoulding, ionen, matoro_gentoo, mehw.is.me, virtualization
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build.log
emerge --info

Description matoro archtester 2021-05-02 02:26:04 UTC
Created attachment 705102 [details]
build.log

=net-libs/gtk-vnc-1.2.0[-vala] fails in configure phase with the following error:

src/meson.build:169:5: ERROR: Unknown variable "with_vala".
Comment 1 matoro archtester 2021-05-02 02:26:36 UTC
Created attachment 705105 [details]
emerge --info
Comment 2 Ionen Wolkens gentoo-dev 2021-05-02 02:51:23 UTC
Seems it's more specifically USE="introspection -vala", works fine if both are disabled.

(please uncompress build.log if under 1MB in the future)
Comment 3 mehw 2021-05-07 23:32:48 UTC
It is fixed with commit https://gitlab.gnome.org/GNOME/gtk-vnc/-/commit/bdab05584bab5c2ecdd508df49b03e80aedd19fc

diff --git a/meson.build b/meson.build
index e9829e606c5c3920631914abef76c9c4832ae06f..777876c30bfbb8950c2a22113509c79ffc4907de 100644
--- a/meson.build
+++ b/meson.build
@@ -318,12 +318,11 @@ gir = find_program('g-ir-scanner', required: get_option('introspection'))
 with_gir = gir.found()
 
 vala_opt = get_option('with-vala')
+with_vala = false
 if not vala_opt.disabled()
   if not with_gir
     if vala_opt.enabled()
       error('Vala API requires GObject introspection (-Dintrospection=true)')
-    else
-      with_vala = false
     endif
   else
     with_vala = add_languages('vala', required: vala_opt)
Comment 4 Larry the Git Cow gentoo-dev 2021-05-08 20:27:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d14d9c87b3884c9b0ae0c901cc2f44733a91a3c

commit 6d14d9c87b3884c9b0ae0c901cc2f44733a91a3c
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2021-05-08 20:21:36 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2021-05-08 20:27:33 +0000

    net-libs/gtk-vnc: Apply patches from upstream
    
    * Replace Python patch with git formatted patch from upstream
    * Apply patch to fix build with USE="intrspection -vala"
    * Replace musl conditional with patch from upstream
    
        Revert "net-libs/gtk-vnc: Fix musl build"
    
        This reverts commit 830c859345812704f6366d4749ad12f1184511f8.
    
    Bug: https://bugs.gentoo.org/737266
    Closes: https://bugs.gentoo.org/787581
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 ...-build-improve-with-coroutine-auto-choice.patch | 59 ++++++++++++++++++++++
 ...ython-explicitly-to-honor-downstream-pyt.patch} | 12 +++--
 ...onfiguration-failure-with-Dwith-vala-disa.patch | 36 +++++++++++++
 net-libs/gtk-vnc/gtk-vnc-1.2.0.ebuild              | 12 ++---
 4 files changed, 106 insertions(+), 13 deletions(-)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-05-10 16:07:27 UTC
*** Bug 789333 has been marked as a duplicate of this bug. ***