Bug 787545

Summary:	sys-apps/portage: emerge CTRL C may be ignored when running pkg_pretend Running pre-merge checks
Product:	Portage Development	Reporter:	Zac Medico <zmedico>
Component:	Core - Interface (emerge)	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kingjon3377
Priority:	Normal	Keywords:	InVCS
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=787416 https://bugs.gentoo.org/show_bug.cgi?id=579526 https://bugs.gentoo.org/show_bug.cgi?id=787563
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	710432
Bug Blocks:	785484

Description Zac Medico gentoo-dev

2021-05-01 21:37:00 UTC

I was trying to reproduce bug 787416 (have not reproduced with portage-3.0.18), and when I pressed CTRL C multiple times after I typed Yes, the pre-merged checks continued:

> Would you like to merge these packages? [Yes/No] Yes         
> >>> Running pre-merge checks for acct-group/gluster-0         
> >>> Running pre-merge checks for acct-group/sshd-0                  
> >>> Running pre-merge checks for acct-group/adm-0
> ^C                                                                                                                                                                                            
>                                                
> Exiting on signal 2
> Fatal Python error: init_import_size: Failed to import the site module
> Python runtime state: initialized
> Traceback (most recent call last):
>   File "/usr/lib/python3.8/site.py", line 580, in <module>
>     main()
>   File "/usr/lib/python3.8/site.py", line 573, in main
>     execsitecustomize()
>   File "/usr/lib/python3.8/site.py", line 512, in execsitecustomize
>     import sitecustomize
>   File "<frozen importlib._bootstrap>", line 991, in _find_and_load
>   File "<frozen importlib._bootstrap>", line 971, in _find_and_load_unlocked
>   File "<frozen importlib._bootstrap>", line 914, in _find_spec
>   File "<frozen importlib._bootstrap_external>", line 1342, in find_spec
>   File "<frozen importlib._bootstrap_external>", line 1314, in _get_spec
>   File "<frozen importlib._bootstrap_external>", line 1443, in find_spec
>   File "<frozen importlib._bootstrap_external>", line 1483, in _fill_cache
> KeyboardInterrupt
> Unable to mount new /proc: -2
> >>> Running pre-merge checks for acct-group/wheel-0
> >>> Running pre-merge checks for acct-group/kmem-0
> ^C>>> Running pre-merge checks for acct-group/tty-0
> ^CUnable to mark /proc slave: -2
> >>> Running pre-merge checks for acct-group/utmp-0
> ^C>>> Running pre-merge checks for acct-group/audio-0
> >>> Running pre-merge checks for acct-group/cdrom-0
> >>> Running pre-merge checks for acct-group/dialout-0
> >>> Running pre-merge checks for acct-group/disk-0
> ^C>>> Running pre-merge checks for acct-group/input-0
> >>> Running pre-merge checks for acct-group/kvm-0
> >>> Running pre-merge checks for acct-group/render-0
> >>> Running pre-merge checks for acct-group/tape-0
> >>> Running pre-merge checks for acct-group/video-0
> >>> Running pre-merge checks for acct-group/systemd-journal-0
> >>> Running pre-merge checks for acct-group/polkitd-0
> >>> Running pre-merge checks for acct-group/lp-0
> >>> Running pre-merge checks for acct-group/lpadmin-0
> >>> Running pre-merge checks for acct-group/messagebus-0
> ^C * The ebuild phase 'die_hooks' has been aborted since PORTAGE_BUILDDIR
>  * does not exist: '/var/tmp/portage/acct-group/messagebus-0'
> >>> Running pre-merge checks for acct-group/systemd-timesync-0
> >>> Running pre-merge checks for acct-group/systemd-resolve-0
> >>> Running pre-merge checks for acct-group/systemd-network-0
> >>> Running pre-merge checks for acct-group/systemd-coredump-0
> >>> Running pre-merge checks for acct-group/systemd-journal-remote-0
> ^Z

Comment 1 Zac Medico gentoo-dev

2021-05-01 21:57:01 UTC

This issue likely arose when the Scheduler _run_pkg_pretend method was converted to a coroutine for the purposes of bug 710432:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=c7fa3f1eb1ce1ebc0d1219dacba555e1a29d5f22

commit c7fa3f1eb1ce1ebc0d1219dacba555e1a29d5f22
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-09-20 00:32:57 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-09-21 05:17:24 +0000

    emerge: enable parallel-fetch during pkg_pretend (bug 710432)
    
    Execute pkg_pretend phases in a coroutine while parallel-fetch
    is running concurrently. When it's time to execute the pkg_pretend
    phase for a remote binary package, use a Scheduler _get_prefetcher
    method to get a running prefetcher if available, and otherwise
    start a new fetcher.
    
    Since pkg_pretend phases now run inside of the --keep-going retry
    loop, --keep-going is now able to recover from pkg_pretend
    failures, which fixes bug 404157.
    
    Bug: https://bugs.gentoo.org/404157
    Bug: https://bugs.gentoo.org/710432
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/_emerge/Scheduler.py | 142 +++++++++++++++++++++++++++++++++--------------
 1 file changed, 99 insertions(+), 43 deletions(-)

Comment 2 Larry the Git Cow gentoo-dev

2021-05-01 22:47:37 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=1eda52d380b39095c6471db8025ab2202fedafc9

commit 1eda52d380b39095c6471db8025ab2202fedafc9
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2021-05-01 22:23:39 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2021-05-01 22:27:41 +0000

    _run_pkg_pretend: raise asyncio.CancelledError when terminated
    
    Bug: https://bugs.gentoo.org/787545
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/_emerge/Scheduler.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comment 3 Larry the Git Cow gentoo-dev

2021-05-24 09:05:18 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cba21902d9a8d1ac07d2ff5b0d932e71fc1fac67

commit cba21902d9a8d1ac07d2ff5b0d932e71fc1fac67
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2021-05-24 07:47:11 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2021-05-24 09:05:08 +0000

    sys-apps/portage: Bump to version 3.0.19
    
     #520378: allow emerge --fetchonly to log to emerge-fetch.log
     #698244: portage(5) document user patch / eapply_user
     #781854: Suggest PORTAGE_LOG_FILTER_FILE_CMD cat fallback
     #782724: sort emerge --unmerge order for determinism
     #783957: lazily evaluate cnf_* variables in tests
     #784566: make emerge insensitive to relative order of optional
                      and positional arguments
     #787545: emerge CTRL C may be ignored when running pkg_pretend
     #787563: ebuild-ipc could handle KeyboardInterrupt
     #788967: emerge --jobs= triggers TypeError
    
    Bug: https://bugs.gentoo.org/785484
    Bug: https://bugs.gentoo.org/788967
    Bug: https://bugs.gentoo.org/787563
    Bug: https://bugs.gentoo.org/787545
    Bug: https://bugs.gentoo.org/784566
    Bug: https://bugs.gentoo.org/783957
    Bug: https://bugs.gentoo.org/782724
    Bug: https://bugs.gentoo.org/781854
    Bug: https://bugs.gentoo.org/698244
    Bug: https://bugs.gentoo.org/520378
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.19.ebuild | 266 +++++++++++++++++++++++++++++++++
 2 files changed, 267 insertions(+)