Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 787266

Summary: media-libs/libzmf - EAPI7, https:// instead of git://
Product: Gentoo Linux Reporter: jospezial <jospezial>
Component: Current packagesAssignee: Gentoo Office Team <office>
Status: UNCONFIRMED ---    
Severity: normal CC: ionen
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 770247    

Description jospezial 2021-05-01 02:45:06 UTC
-# Copyright 1999-2019 Gentoo Authors
+# Copyright 1999-2021 Gentoo Authors
 
-EAPI=6
+EAPI=7
 
-EGIT_REPO_URI="git://gerrit.libreoffice.org/libzmf"
+EGIT_REPO_URI="https://git.libreoffice.org/libzmf"

Please also sync both ebuilds.
Maybe a snapshot with latest commits would be good.

The logic with "||" in the ebuild is not easy. I needed some time to understand how it works and still wonder that it works.
Comment 1 Ionen Wolkens gentoo-dev 2021-05-01 03:10:49 UTC
(In reply to jospezial from comment #0)
> Maybe a snapshot with latest commits would be good.
Doesn't seem to have received many changes since 0.0.2, although the commits about more pkg-config usage and removing default -Werror wouldn't hurt.

For this package I kind of question the need to keep the -9999 ebuild (along with the non-common || 9999 checks).
Comment 2 Andreas Sturmlechner gentoo-dev 2021-05-01 09:45:14 UTC
We don't do snapshots without a pressing need.
Comment 3 Andreas Sturmlechner gentoo-dev 2021-05-01 10:04:15 UTC
(In reply to jospezial from comment #0)
> The logic with "||" in the ebuild is not easy. I needed some time to
> understand how it works and still wonder that it works.

Wonder no more then. ;) It is far from unusual and the ebuild style was fairly common at the time I started working on office ebuilds.
Comment 4 Larry the Git Cow gentoo-dev 2021-08-03 14:06:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=59ec5e0556b3c9df5d552fa9b68e9dca268e97c3

commit 59ec5e0556b3c9df5d552fa9b68e9dca268e97c3
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-08-03 13:36:19 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-08-03 14:06:39 +0000

    media-libs/libzmf: EAPI-8 bump, https, consolidate live/release ifdefs
    
    Bug: https://bugs.gentoo.org/787266
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-libs/libzmf/libzmf-9999.ebuild | 36 ++++++++++++++++++++----------------
 1 file changed, 20 insertions(+), 16 deletions(-)