Bug 78471

Summary:	deleted files not touched by Samba's recycle VFS module
Product:	Gentoo Linux	Reporter:	Surakshan Mendis <bug.tracker>
Component:	[OLD] Server	Assignee:	Gentoo's SAMBA Team <samba>
Status:	RESOLVED INVALID
Severity:	major
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Surakshan Mendis 2005-01-17 23:33:31 UTC

I've set up samba as a domain controller, I've enabled the recycle module in the [homes] so when a user deletes a file it is moved to the .salvage directory. Whilst the file moves when deleted, the times are not modified on the file even thought recycle:touch = yes. This means I cannot use an autodelete scriopt because the timestamps do not change

My home share looks like this:[homes]
comment = Home Directories
valid users = %S
read only = No
browseable = No
force create mode = 0700
valid users = @ntadmins @ntresident
# Hide files that linux permissions prevent access to
hide unreadable = yes

create mask = 0700
directory mask = 0700

vfs objects = recycle
 recycle:repository = .salvage
 recycle:keeptree = yes
 recycle:touch = yes
 recycle:versions = Yes
 recycle:exclude = ?~$*,~$*,*.tmp,*.temp,*.TMP
 recycle:exclude_dir = /tmp,/temp,/cache
 recycle:noversions = *.doc

The file system is reisferfs, quota is enabled and working, the fstab entry for the filesystem is:

/dev/hda3               /               reiserfs        notail,usrquota,grpquota 0 1

I can as root or as the samba users linux account manually touch files using the touch command

I've looked for suggestions, but there's nothing!
Using samba 3.0.9 and tried also 3.0.10 both are the same

Reproducible: Always
Steps to Reproduce:
1. Set up recycle module with recycle:touch=yes
2. Delete a file
3.

Actual Results:  
file not touched (but moved as expected)

Expected Results:  
file moved AND touched.

Comment 1 Surakshan Mendis 2005-01-21 22:12:38 UTC

Looking at the source code its clearly changing the last access date, and setting the last modified date to what it originally got from stat.

So whats been seen is normal and not a bug, but I may submit a patch with option to samba that also changes the modified time.

Windows is quite willing to change the access time when just viewing a folder of files due to autoview etc... and it reduces the value of touching files with the idea of later deleting them based on date.