| Summary: | gtk-qt-engine-0.6-r1 has wrong slot | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | James Roberts-Thomson <james.roberts-thomson> |
| Component: | New packages | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Patch to fix SLOT issue | ||
Created attachment 48806 [details, diff]
Patch to fix SLOT issue
This patch (which only moves the "need-kde 3" line) is enough to fix the SLOT
issue - I guess somehow the "need-kde" function is clearing the SLOT setting.
At the moment our eclasses force SLOT to be 0 for non kde-base ebuilds, should we change that, or we just allow SLOT to be overridden after need-kde() has been called? First of all the patch to the ebuild should be applied - can someone who has it emerged do that? motaboy? =============== need-kde() sets SLOT=0 for non-kdebase ebuilds. But kde.eclass already sets SLOT=0 (unconditionally) in its global section. Therefore the former should be removed - AFAICS nothing would break. But when changing such a central function, I want to day to reflect to make sure nothing is broken :-) OK to commit? I've fixed the ebuild keeping the call to "need-kde" in the same place (after DEPEND as should be) but setting SLOT=2 after it. Looks to be fixed to me. |
The gtk-qt-engine-0.6-r1 ebuild has the wrong SLOT, as shown here: # etcat -v gtk-qt-engine [ Results for search key : gtk-qt-engine ] [ Candidate applications found : 3 ] Only printing found installed programs. * x11-themes/gtk-qt-engine : [ ~ ] 0.5 (2) [ I] 0.6 (2) [ I] 0.6-r1 (0) As can be seen, both 0.6 and 0.6-r1 are installed due to this SLOT error. The ebuild does set SLOT="2", but this seems to be overridden by something else. Reproducible: Always Steps to Reproduce: Expected Results: emerging gtk-qt-engine-0.6-r1 should cause gtk-qt-engine-0.6 to be removed as part of the autoclean.